From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] gpiolib: Add comments explaining the _cansleep() WARN_ON()s
Date: Fri, 17 Feb 2012 10:45:12 -0800 [thread overview]
Message-ID: <20120217184512.GF10146@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdYuBpeKSe3HtWW8Nu=z-tnOTCCCkjvbnf8uu_udJ8Matw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On Fri, Feb 17, 2012 at 07:41:33PM +0100, Linus Walleij wrote:
> On Fri, Feb 17, 2012 at 7:24 PM, Mark Brown
> > + /* Should be using gpio_get_value_cansleep() or a different GPIO */
> > WARN_ON(chip->can_sleep);
> Actually I cannot parse the "or a different GPIO" part.
> If this means that the user may be addressing the wrong GPIO pin,
> then we could spell that out I presume, but maybe you are referring
> to something else?
It was intended as a hint that if you really need to be in atomic
context to do whatever this isn't the GPIO for you but in retrospect
it's probably not actually useful advice for most users. I'll respin.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-17 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 18:24 [PATCH] gpiolib: Add comments explaining the _cansleep() WARN_ON()s Mark Brown
2012-02-17 18:41 ` Linus Walleij
2012-02-17 18:45 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-17 18:46 Mark Brown
2012-02-17 18:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217184512.GF10146@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox