From: Evgeniy Polyakov <zbr@ioremap.net>
To: Michael Thalmeier <michael.thalmeier@hale.at>
Cc: linux-kernel@vger.kernel.org, michael@thalmeier.at
Subject: Re: [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L
Date: Sat, 18 Feb 2012 13:39:47 +0300 [thread overview]
Message-ID: <20120218103947.GB13028@ioremap.net> (raw)
In-Reply-To: <1329480422-7616-1-git-send-email-michael.thalmeier@hale.at>
Hi
On Fri, Feb 17, 2012 at 01:07:02PM +0100, Michael Thalmeier (michael.thalmeier@hale.at) wrote:
> This driver adds support for some Dallas non-volatile memory 1-wire slave
> devices.
>
> At the moment the following devices are supported:
>
> * family 0x0c: DS1996 64Kb Memory iButton
> * family 0x1A: DS1963L 4kbit Monetary
>
> Access to memory is done via pages exportedi in sysfs.
>
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
Looks good to me, although I would replace config option
with sysfs-enabled parameter, since distros do not compile different
kernels with various options enabled.
--
Evgeniy Polyakov
prev parent reply other threads:[~2012-02-18 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 12:07 [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L Michael Thalmeier
2012-02-18 10:39 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120218103947.GB13028@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thalmeier@hale.at \
--cc=michael@thalmeier.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox