From: NeilBrown <neilb@suse.de>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: GregKH <greg@kroah.com>, Thomas Weber <weber@corscience.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.de>
Subject: [PATCH 1/3] w1_bq27000: remove unnecessary NULL test.
Date: Sun, 19 Feb 2012 13:10:00 +1100 [thread overview]
Message-ID: <20120219021000.4958.45388.stgit@notabene.brown> (raw)
In-Reply-To: <20120219020910.4958.46866.stgit@notabene.brown>
As recent change means that we now dereference 'dev' before testing
for NULL.
That means either the change was wrong, or the test isn't needed.
As this function is only called from one driver (bq27x000_battery) and
it always passed a non-NULL dev, it seems good to assume that the
test isn't needed.
So remove it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---
drivers/w1/slaves/w1_bq27000.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c
index 8f10fd2..50d9af7 100644
--- a/drivers/w1/slaves/w1_bq27000.c
+++ b/drivers/w1/slaves/w1_bq27000.c
@@ -45,9 +45,6 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg)
u8 val;
struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);
- if (!dev)
- return 0;
-
w1_write_8(sl->master, HDQ_CMD_READ | reg);
val = w1_read_8(sl->master);
next prev parent reply other threads:[~2012-02-19 2:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 2:10 [PATCH 0/3] Small fixes for w1_bq27000 driver NeilBrown
2012-02-19 2:10 ` [PATCH 2/3] w1_bq27000 - remove w1_bq27000_write NeilBrown
2012-02-19 2:10 ` NeilBrown [this message]
2012-02-19 2:10 ` [PATCH 3/3] w1_bq27000: Only one thread can access the bq27000 at a time NeilBrown
2012-02-19 6:50 ` [PATCH 0/3] Small fixes for w1_bq27000 driver Thomas Weber
2012-02-19 7:06 ` NeilBrown
2012-02-20 11:19 ` Thomas Weber
2012-02-20 13:56 ` [PATCH] OMAP: hdq: software-supervised control of HDQ_ICLK Thomas Weber
2012-02-20 15:22 ` Evgeniy Polyakov
2012-02-20 12:04 ` [PATCH 0/3] Small fixes for w1_bq27000 driver Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219021000.4958.45388.stgit@notabene.brown \
--to=neilb@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weber@corscience.de \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).