From: Dan Carpenter <dan.carpenter@oracle.com>
To: santosh prasad nayak <santoshprasadnayak@gmail.com>
Cc: mfm@muteddisk.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: driver usbip: Code cleanup
Date: Sun, 19 Feb 2012 22:57:51 +0300 [thread overview]
Message-ID: <20120219195751.GE2855@mwanda> (raw)
In-Reply-To: <CAOD=uF4st80fB0+uwXNNbHtN4YpoFWwu4EUhwmVi+v=0euu=sQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Sun, Feb 19, 2012 at 05:48:39PM +0530, santosh prasad nayak wrote:
> Code cleanup: removed commented code of old style lock initilization
>
1) The patch is line wrapped so it doesn't apply. To test, save
your email as raw text. `cat raw_email.txt | git am`
Read Documentation/email-clients.txt.
2) The subject could be improved. Do a:
git log --pretty=oneline drivers/staging/usbip/stub_dev.c | head
to see the correct prefix to use.
3) Instead of "Code cleanup" choose a more descriptive name like
"Delete commented code."
4) Use your full name for the Signed-off-by line.
Please fix these and resend.
If you want, you can leave linux-usb@vger.kernel.org and
linux-kernel@vger.kernel.org off the CC list, because no one on
those lists care about trivial patches to the Staging tree.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-19 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 12:18 [PATCH] Staging: driver usbip: Code cleanup santosh prasad nayak
2012-02-19 19:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219195751.GE2855@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox