Re: [PATCH v5 2/5] Extcon: support notification based on the state changes.

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Fri, Feb 10, 2012 at 03:40:35PM +0900, MyungJoo Ham wrote:
> From: Donggeun Kim <dg77.kim@samsung.com>

> State changes of extcon devices have been notified via kobjet_uevent.
> This patch adds notifier interfaces in order to allow device drivers to
> get notified easily. Along with notifier interface,
> extcon_get_extcon_dev() function is added so that device drivers may
> discover a extcon_dev easily.

Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

This is something I'd been going to ask for.  One related thing which
needs some thought is how we combine extcon detection methods for
hardware which uses multiple unrelated detection methods.  One of the
common examples for audio jacks is that you might have an ultra low
power detection method for detecting if something is physically present
in the jack and then use that to start up additional detection methods
that can tell what that thing actually is.  The two provide different
pieces of the picture reported to userspace.

With the ALSA and input accessory reporting methods we've got bitmasks
so this can be implemented fairly naturally but with the ABI that we've
got from Android here things aren't so easy as we need to go down to a
single value.  Perhaps some sort of bitmask to value translation layer?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]