From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.de>,
"Randy Dunlap" <rdunlap@xenotime.net>,
"Mike Lockwood" <lockwood@android.com>,
"Arve Hjønnevag" <arve@android.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Donggeun Kim" <dg77.kim@samsung.com>, "Greg KH" <gregkh@suse.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Morten CHRISTIANSEN" <morten.christiansen@stericsson.com>,
"John Stultz" <john.stultz@linaro.org>,
"Joerg Roedel" <joerg.roedel@amd.com>,
myungjoo.ham@gmail.com
Subject: Re: [PATCH v5 3/5] Extcon: support multiple states at a device.
Date: Sun, 19 Feb 2012 18:24:33 -0800 [thread overview]
Message-ID: <20120220022430.GI3194@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328856038-21912-4-git-send-email-myungjoo.ham@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On Fri, Feb 10, 2012 at 03:40:36PM +0900, MyungJoo Ham wrote:
> + [EXTCON_AUDIO_IN] = "Audio-in",
> + [EXTCON_AUDIO_OUT] = "Audio-out",
Can I suggest making these more specific - how about
[EXTCON_LINE_IN] = "Line-in",
[EXTCON_LINE_OUT] = "Line-out",
[EXTCON_MIC_IN] = "Microphone",
[EXTCON_HEADPHONE_OUT] = "Headphone",
as a starting point? The distinction between line and the other two is
often pretty important from a UI/system interaction point of view.
> + /* TODO: remove before submit */
> + pr_info("[%s][%d]\n", buffer, enabled);
:)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-20 2:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 9:46 [PATCH v3 0/4] introduce External Connector Class (extcon) MyungJoo Ham
2012-01-11 9:46 ` [PATCH v3 1/4] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-01-11 9:46 ` [PATCH v3 2/4] Extcon: support notification based on the state changes MyungJoo Ham
2012-01-11 9:46 ` [PATCH v3 3/4] Extcon: support multiple states at a device MyungJoo Ham
2012-01-11 9:46 ` [PATCH v3 4/4] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-01-20 1:01 ` [PATCH v4 0/4] introduce External Connector Class (extcon) MyungJoo Ham
2012-01-20 1:01 ` [PATCH v4 1/4] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-01-20 1:01 ` [PATCH v4 2/4] Extcon: support notification based on the state changes MyungJoo Ham
2012-01-20 1:01 ` [PATCH v4 3/4] Extcon: support multiple states at a device MyungJoo Ham
2012-01-20 1:01 ` [PATCH v4 4/4] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-02-10 6:40 ` [PATCH v5 0/5] Introduce External Connector Class (extcon) MyungJoo Ham
2012-02-10 6:40 ` [PATCH v5 1/5] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-02-20 1:54 ` Mark Brown
2012-02-20 6:17 ` MyungJoo Ham
2012-02-20 15:45 ` Mark Brown
2012-02-10 6:40 ` [PATCH v5 2/5] Extcon: support notification based on the state changes MyungJoo Ham
2012-02-20 2:20 ` Mark Brown
2012-02-10 6:40 ` [PATCH v5 3/5] Extcon: support multiple states at a device MyungJoo Ham
2012-02-20 2:24 ` Mark Brown [this message]
2012-02-20 7:02 ` MyungJoo Ham
2012-02-22 10:07 ` Arnd Bergmann
2012-02-10 6:40 ` [PATCH v5 4/5] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-02-20 2:27 ` Mark Brown
2012-02-22 8:23 ` MyungJoo Ham
2012-02-22 10:00 ` Arnd Bergmann
2012-02-24 4:56 ` MyungJoo Ham
2012-02-24 12:53 ` Arnd Bergmann
2012-02-27 6:47 ` MyungJoo Ham
2012-02-10 6:40 ` [PATCH v5 5/5] Extcon: adc-jack driver to support 3.5 pi or simliar devices MyungJoo Ham
2012-02-10 16:25 ` Mark Brown
2012-02-14 2:22 ` MyungJoo Ham
2012-02-14 5:58 ` Mark Brown
2012-02-27 12:15 ` [PATCH v6 0/5] Introduce External Connector Class (extcon) MyungJoo Ham
2012-02-27 12:15 ` [PATCH v6 1/5] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-03-09 12:41 ` Mark Brown
2012-03-12 8:06 ` MyungJoo Ham
2012-03-29 22:27 ` Erik Gilling
2012-03-30 8:56 ` MyungJoo Ham
2012-03-30 10:14 ` Mark Brown
2012-03-30 10:07 ` Mark Brown
2012-03-30 17:29 ` Erik Gilling
2012-03-30 17:38 ` Dima Zavin
2012-04-02 5:09 ` MyungJoo Ham
2012-03-31 10:19 ` Mark Brown
2012-02-27 12:15 ` [PATCH v6 2/5] Extcon: support generic GPIO extcon driver MyungJoo Ham
2012-03-29 22:37 ` Stephen Boyd
2012-03-30 8:33 ` MyungJoo Ham
2012-02-27 12:15 ` [PATCH v6 3/5] Extcon: support notification based on the state changes MyungJoo Ham
2012-02-27 12:15 ` [PATCH v6 4/5] Extcon: support multiple states at a device MyungJoo Ham
2012-02-27 12:15 ` [PATCH v6 5/5] Extcon: support mutually exclusive relation between cables MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220022430.GI3194@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=dg77.kim@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=joerg.roedel@amd.com \
--cc=john.stultz@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lockwood@android.com \
--cc=morten.christiansen@stericsson.com \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=neilb@suse.de \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).