* [PATCH] Staging: usbip: Remove commented code.
@ 2012-02-20 3:14 santosh nayak
2012-02-20 6:37 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: santosh nayak @ 2012-02-20 3:14 UTC (permalink / raw)
To: mfm
Cc: dan.carpenter, gregkh, linux-usb, devel, linux-kernel,
kernel-janitors, santosh.iitg, Santosh Nayak
From: Santosh Nayak <santoshprasadnayak@gmail.com>
Remove commented code of old style lock initilization
Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
drivers/staging/usbip/stub_dev.c | 2 --
drivers/staging/usbip/vhci_hcd.c | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index 03420e2..fa870e3 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -297,7 +297,6 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev,
sdev->devid = (busnum << 16) | devnum;
sdev->ud.side = USBIP_STUB;
sdev->ud.status = SDEV_ST_AVAILABLE;
- /* sdev->ud.lock = SPIN_LOCK_UNLOCKED; */
spin_lock_init(&sdev->ud.lock);
sdev->ud.tcp_socket = NULL;
@@ -306,7 +305,6 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev,
INIT_LIST_HEAD(&sdev->priv_free);
INIT_LIST_HEAD(&sdev->unlink_free);
INIT_LIST_HEAD(&sdev->unlink_tx);
- /* sdev->priv_lock = SPIN_LOCK_UNLOCKED; */
spin_lock_init(&sdev->priv_lock);
init_waitqueue_head(&sdev->tx_waitq);
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index 8d96ab0..dca9bf1 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -895,14 +895,12 @@ static void vhci_device_init(struct vhci_device *vdev)
vdev->ud.side = USBIP_VHCI;
vdev->ud.status = VDEV_ST_NULL;
- /* vdev->ud.lock = SPIN_LOCK_UNLOCKED; */
spin_lock_init(&vdev->ud.lock);
INIT_LIST_HEAD(&vdev->priv_rx);
INIT_LIST_HEAD(&vdev->priv_tx);
INIT_LIST_HEAD(&vdev->unlink_tx);
INIT_LIST_HEAD(&vdev->unlink_rx);
- /* vdev->priv_lock = SPIN_LOCK_UNLOCKED; */
spin_lock_init(&vdev->priv_lock);
init_waitqueue_head(&vdev->waitq_tx);
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: usbip: Remove commented code.
2012-02-20 3:14 [PATCH] Staging: usbip: Remove commented code santosh nayak
@ 2012-02-20 6:37 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-02-20 6:37 UTC (permalink / raw)
To: santosh nayak
Cc: mfm, gregkh, linux-usb, devel, linux-kernel, kernel-janitors,
santosh.iitg
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
On Mon, Feb 20, 2012 at 08:44:05AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Remove commented code of old style lock initilization
>
Looks good. Thanks for doing that.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-20 6:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-20 3:14 [PATCH] Staging: usbip: Remove commented code santosh nayak
2012-02-20 6:37 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).