From: Ingo Molnar <mingo@elte.hu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/
Date: Mon, 20 Feb 2012 09:25:30 +0100 [thread overview]
Message-ID: <20120220082529.GA23502@elte.hu> (raw)
In-Reply-To: <1329664319-3128-3-git-send-email-geert@linux-m68k.org>
* Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>"
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: x86@kernel.org
> ---
> arch/x86/boot/compressed/head_32.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
> index a055993..a37b117 100644
> --- a/arch/x86/boot/compressed/head_32.S
> +++ b/arch/x86/boot/compressed/head_32.S
> @@ -173,7 +173,7 @@ relocated:
> call decompress_kernel
> addl $20, %esp
>
> -#if CONFIG_RELOCATABLE
> +#ifdef CONFIG_RELOCATABLE
> /*
> * Find the address of the relocations.
> */
I'd really prefer to read an actual "this is safe, because this
value is defined in the Kconfig as ..." type of commit log
instead of nothing, which would ensure us that you didnt just do
a (fundamentally unsafe) sed job over the kernel tree but
actually have *read* the Kconfig entries in question to ensure
the correctness of your patches...
Thanks,
Ingo
next prev parent reply other threads:[~2012-02-20 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 15:11 [PATCH 1/5] blackfin: s/#if CONFIG/#ifdef CONFIG/ Geert Uytterhoeven
2012-02-19 15:11 ` [PATCH 2/5] microblaze: s/#if[!] CONFIG/#if[n]def CONFIG/ Geert Uytterhoeven
2012-02-20 0:27 ` [microblaze-linux] " John Williams
2012-02-20 11:59 ` Geert Uytterhoeven
2012-02-20 23:53 ` John Williams
2012-02-19 15:11 ` [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/ Geert Uytterhoeven
2012-02-20 8:25 ` Ingo Molnar [this message]
2012-02-19 15:11 ` [PATCH 4/5] input: " Geert Uytterhoeven
2012-02-19 15:11 ` [PATCH 5/5] fbdev: " Geert Uytterhoeven
2012-02-19 22:44 ` Florian Tobias Schandinat
2012-04-06 0:00 ` Jiri Kosina
2012-02-19 20:08 ` [PATCH 1/5] blackfin: " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220082529.GA23502@elte.hu \
--to=mingo@elte.hu \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).