From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pradheep Shrinivasan <pradheep.sh@gmail.com>
Cc: gregkh@linuxfoundation.org, lucas.demarchi@profusion.mobi,
devel@driverdev.osuosl.org, devel@linuxdriverproject.org,
Andy Whitcroft <apw@canonical.com>,
joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings in Version.h
Date: Mon, 20 Feb 2012 22:09:52 +0300 [thread overview]
Message-ID: <20120220190952.GN2912@mwanda> (raw)
In-Reply-To: <CANz8tm3t5HM9QeNk+h4gNtbTs2UUW1qOe0t=TgnuSD3_gw_A7Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Tue, Feb 21, 2012 at 12:13:40AM +0530, Pradheep Shrinivasan wrote:
> Hi Dan
>
> I remember the bug .. but i think in this case it would be ok as it does
> not look that weird as in the case of the single character brackets.
>
> In case you feel it is totally un necessary i can fix it and send the patch
> again.
So are you asking me, are the parenthesis totally unnecessary? Yes.
Absolutely. How could that macro possibly be expanded in a way that
would cause a bug.
Are you asking me if I think the code is better without unneeded
parenthesis? Yes again.
Are you asking me if I'm going to NAK your patch? No. It's an
unfortunate thing. Checkpatch.pl is going around telling people to
add bogus parenthesis everywhere, and no one likes to redo their
patches. And I feel like a jerk for telling people that they should
redo their patches. And checkpatch.pl is a robot which has more
energy than I do.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-20 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4f428dfc.e302440a.02ba.6747@mx.google.com>
2012-02-20 18:31 ` [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings in Version.h Dan Carpenter
[not found] ` <CANz8tm3t5HM9QeNk+h4gNtbTs2UUW1qOe0t=TgnuSD3_gw_A7Q@mail.gmail.com>
2012-02-20 19:09 ` Dan Carpenter [this message]
[not found] ` <CANz8tm16FvLjUbgPWTsiz5WTje-bRCEAE1eWx3=F48Lm66-Tyg@mail.gmail.com>
2012-02-22 11:21 ` Andy Whitcroft
2012-02-22 13:51 ` Macros with complex values should be enclosed in parenthesis Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220190952.GN2912@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=pradheep.sh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).