From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2012-02-20
Date: Tue, 21 Feb 2012 14:44:17 -0500 (EST) [thread overview]
Message-ID: <20120221.144417.1445117001833888214.davem@davemloft.net> (raw)
In-Reply-To: <20120221151435.GA19354@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Tue, 21 Feb 2012 10:14:36 -0500
> On Mon, Feb 20, 2012 at 07:23:24PM -0500, David Miller wrote:
>> From: "John W. Linville" <linville@tuxdriver.com>
>> Date: Mon, 20 Feb 2012 15:37:40 -0500
>>
>> > Here is another batch of fixes intended for 3.3. Most of the fixes
>> > this time are for Bluetooth.
>>
>> Pulled, but please read the bluetooth changes more carefully in the
>> future, there were a lot of coding style errors introduced this
>> time around.
>
> I pinged Johan about this, and he tells me that he spoke to Marcel
> as well. They were a bit unsure about the issue. Is your concern
> primarily about some excessive tabbing for indentation of parameters
> and such?
So you actually looked at the changes you pushed to me and you are
telling me you personally can't find anything that looks like garbage?
Really? Do I really have to point out such obvious stuff like this?
Are you serious?
Look at ca0d6c7ece0e78268cd7c5c378d6b1b610625085 ("Bluetooth: Add
missing QUIRK_NO_RESET test to hci_dev_do_close")
You tell me what the heck you think of this thing.
- if (!test_bit(HCI_RAW, &hdev->flags)) {
+ if (!test_bit(HCI_RAW, &hdev->flags) &&
+ test_bit(HCI_QUIRK_NO_RESET, &hdev->quirks)) {
That's disgusting, it jumps off the screen and says "Hello, I am ugly
as sin". How in the world can you miss something like this? Four
TABs on the second line? Why? I can't believe we even have to discuss
something like this, seriously.
Commit 6e1da683f79a22fafaada62d547138daaa9e3456 ("Bluetooth: l2cap_set_timer
needs jiffies as timeout value"):
- __set_chan_timer(chan, L2CAP_DISC_REJ_TIMEOUT);
+ __set_chan_timer(chan,
+ msecs_to_jiffies(L2CAP_DISC_REJ_TIMEOUT));
You can't see that mis-tabbed thing on the second new line? Really?
The list goes on and on, just walk through the bluetooth commits from
the other day, stuff like this is all over the place.
next prev parent reply other threads:[~2012-02-21 19:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 20:37 pull request: wireless 2012-02-20 John W. Linville
2012-02-21 0:23 ` David Miller
2012-02-21 15:14 ` John W. Linville
2012-02-21 19:44 ` David Miller [this message]
2012-02-21 20:38 ` Andrei Emeltchenko
2012-02-21 20:40 ` David Miller
2012-02-21 20:59 ` [PATCH] checkpatch: Add some --strict coding style checks Joe Perches
2012-02-21 21:09 ` Andrew Morton
2012-02-21 21:11 ` Joe Perches
2012-02-21 22:09 ` Allan, Bruce W
2012-02-21 23:16 ` Joe Perches
2012-02-22 1:36 ` Joe Perches
2012-02-22 1:56 ` Allan, Bruce W
2012-02-22 1:58 ` Joe Perches
2012-02-22 2:17 ` Allan, Bruce W
2012-02-23 3:43 ` Joe Perches
2012-02-24 18:22 ` Allan, Bruce W
2012-02-24 18:37 ` [PATCH v2] " Joe Perches
2012-02-29 14:38 ` Kalle Valo
2012-02-22 9:35 ` [PATCH] " David Laight
2012-02-22 9:46 ` Johannes Berg
2012-02-22 10:07 ` pull request: wireless 2012-02-20 Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221.144417.1445117001833888214.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).