From: Stephen Hemminger <shemminger@vyatta.com>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: Danny Kukawka <dkukawka@suse.de>,
"David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] br_device: unify return value of .ndo_set_mac_address if address is invalid
Date: Tue, 21 Feb 2012 09:22:13 -0800 [thread overview]
Message-ID: <20120221092213.12015034@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1329826072-14689-5-git-send-email-danny.kukawka@bisect.de>
On Tue, 21 Feb 2012 13:07:52 +0100
Danny Kukawka <danny.kukawka@bisect.de> wrote:
> Unify return value of .ndo_set_mac_address if the given address
> isn't valid. Return -EADDRNOTAVAIL as eth_mac_addr() already does
> if is_valid_ether_addr() fails.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
> ---
> net/bridge/br_device.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
> index a157bf8..ba829de 100644
> --- a/net/bridge/br_device.c
> +++ b/net/bridge/br_device.c
> @@ -167,7 +167,7 @@ static int br_set_mac_address(struct net_device *dev, void *p)
> struct sockaddr *addr = p;
>
> if (!is_valid_ether_addr(addr->sa_data))
> - return -EINVAL;
> + return -EADDRNOTAVAIL;
>
> spin_lock_bh(&br->lock);
> if (compare_ether_addr(dev->dev_addr, addr->sa_data)) {
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2012-02-21 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 12:07 [PATCH 0/4] Part 1: unify return value of .ndo_set_mac_address if address is invalid Danny Kukawka
2012-02-21 12:07 ` [PATCH 1/4] ethernet: " Danny Kukawka
2012-02-21 12:07 ` [PATCH 2/4] mcs7830: " Danny Kukawka
2012-02-21 12:07 ` [PATCH 3/4] Staging: et131x: " Danny Kukawka
2012-02-21 12:07 ` [PATCH 4/4] br_device: " Danny Kukawka
2012-02-21 17:22 ` Stephen Hemminger [this message]
2012-02-23 22:12 ` [PATCH 0/4] Part 1: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221092213.12015034@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=danny.kukawka@bisect.de \
--cc=davem@davemloft.net \
--cc=dkukawka@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox