From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Simplify debugfs code
Date: Tue, 21 Feb 2012 09:40:00 +0000 [thread overview]
Message-ID: <20120221094000.GA3079@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1329807042-19090-1-git-send-email-sboyd@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On Mon, Feb 20, 2012 at 10:50:42PM -0800, Stephen Boyd wrote:
> Update the code to reflect this. We gain an extra dentry pointer
> per struct regulator and struct regulator_dev but that should be
> ok because most distros have debugfs compiled in anyway.
It'd be helpful if the changelog were a little less oblique about what
the resulting changes were... either mention what the changes are or
mention what the current state of the code is. Makes it much easier to
work out if the patch is doing what it's supposed to. This was also an
issue with the original patch, it wasn't at all clear what the actual
intention was.
Anyway, I'll apply.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-21 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-Id: <1329772500-20577-1-git-send-email-broonie@opensource.wolfsonmicro.com>
2012-02-21 6:50 ` [PATCH] regulator: Simplify debugfs code Stephen Boyd
2012-02-21 9:40 ` Mark Brown [this message]
2012-02-20 21:15 [PATCH] regulator: Clean up debugfs error handling a bit Mark Brown
2012-02-21 6:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221094000.GA3079@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox