From: Dong Aisheng <aisheng.dong@freescale.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@nvidia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
<B29396@freescale.com>, <s.hauer@pengutronix.de>,
<dongas86@gmail.com>, <shawn.guo@linaro.org>,
<thomas.abraham@linaro.org>, <tony@atomide.com>,
<linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 11/20] pinctrl: Downgrade pinctrl_get warning when no maps are found
Date: Wed, 22 Feb 2012 14:56:48 +0800 [thread overview]
Message-ID: <20120222065647.GE11087@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <CACRpkdbpBZqUUwxwF8o8P1P9yknY7SRSzGmYsa3kQ1JH=QNJ7A@mail.gmail.com>
On Tue, Feb 21, 2012 at 02:51:55PM +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote:
>
> > This may be perfectly legitimate. An IP block may get re-used
> > across SoCs. Not all of those SoCs may need pinmux settings for the
> > IP block, e.g. if one SoC dedicates pins to that function but
> > another doesn't. The driver won't know this, and will always
> > attempt to set up the pinmux. The mapping table defines whether any
> > HW programming is actually needed.
> >
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> This is equivalent to providing dummy pincontrollers as was on my
> TODO for a while admittedly.
>
> For consistency with regulators it would maybe be better to have
> optional dummy pin controllers but after thinking a bit about it
> I think this is more helpful, so I applied it anyway.
>
> However I would invite more opinions...
>
I'm afraid this is a little error-prone, that means even we specifed
the wrong map name or state name, the pinctrl_get still does not get
failed and it is a little different as what we want in this patch.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-02-22 6:48 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 6:45 [PATCH 00/20] pinctrl: API change, config in mapping table Stephen Warren
2012-02-20 6:45 ` [PATCH 01/20] pinctrl: pinctrl_register_mappings() shouldn't be __init Stephen Warren
2012-02-20 21:01 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 02/20] pinctrl: use list_add_tail instead of list_add Stephen Warren
2012-02-20 21:03 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 03/20] pinctrl: Store mapping table as a list of chunks Stephen Warren
2012-02-20 21:08 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 04/20] pinctrl: Record a pin owner, not mux function, when requesting pins Stephen Warren
2012-02-20 21:15 ` Linus Walleij
2012-02-21 17:23 ` Stephen Warren
2012-02-22 6:17 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 05/20] pinctrl: Re-order pinmux.[ch] to match each-other Stephen Warren
2012-02-20 21:17 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 06/20] pinctrl: Re-order pinconf.[ch] " Stephen Warren
2012-02-20 21:18 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 07/20] pinctrl: core.c/h cleanups Stephen Warren
2012-02-20 21:20 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 08/20] pinctrl: Assume map table entries can't have a NULL name field Stephen Warren
2012-02-20 21:42 ` Linus Walleij
2012-02-21 13:09 ` Dong Aisheng
2012-02-21 13:12 ` Linus Walleij
2012-02-21 17:46 ` Stephen Warren
2012-02-22 6:13 ` Linus Walleij
2012-02-22 6:34 ` Dong Aisheng
2012-02-22 18:05 ` Stephen Warren
2012-02-23 3:35 ` Dong Aisheng
2012-02-23 3:39 ` Stephen Warren
2012-02-23 3:56 ` Dong Aisheng
2012-02-23 3:53 ` Stephen Warren
2012-02-23 4:48 ` Dong Aisheng
2012-02-23 16:39 ` Stephen Warren
2012-02-24 8:40 ` Dong Aisheng
2012-02-21 13:08 ` Dong Aisheng
2012-02-21 17:38 ` Stephen Warren
2012-02-22 6:21 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 09/20] pinctrl: Disallow map table entries with NULL dev_name field Stephen Warren
2012-02-20 21:49 ` Linus Walleij
2012-02-22 6:46 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 10/20] pinctrl: Assume map table entries can't have a NULL ctrl_dev_name field Stephen Warren
2012-02-21 13:36 ` Linus Walleij
2012-02-22 6:49 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 11/20] pinctrl: Downgrade pinctrl_get warning when no maps are found Stephen Warren
2012-02-21 13:51 ` Linus Walleij
2012-02-22 5:54 ` Shawn Guo
2012-02-22 6:56 ` Dong Aisheng [this message]
2012-02-22 17:21 ` Stephen Warren
2012-02-23 3:48 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 12/20] pinctrl: Use dev_*() instead of pr_*(), add some msgs, minor cleanups Stephen Warren
2012-02-22 6:23 ` Linus Walleij
2012-02-22 7:01 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 13/20] pinctrl: Error if mapping table's control dev can't be found Stephen Warren
2012-02-21 13:58 ` Linus Walleij
2012-02-21 17:50 ` Stephen Warren
2012-02-20 6:45 ` [PATCH 14/20] pinctrl: Allocate sizeof(*p) instead of sizeof(struct foo) Stephen Warren
2012-02-22 6:25 ` Linus Walleij
2012-02-22 7:04 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 15/20] pinctrl: Fix and simplify locking Stephen Warren
2012-02-22 17:38 ` Linus Walleij
2012-02-22 18:26 ` Stephen Warren
2012-02-23 0:18 ` Stephen Warren
2012-02-20 6:45 ` [PATCH 16/20] pinctrl: Refactor struct pinctrl handling in core.c vs pinmux.c Stephen Warren
2012-02-22 17:18 ` Linus Walleij
2012-02-24 16:55 ` Dong Aisheng
2012-02-20 6:45 ` [PATCH 17/20] pinctrl: Add usecount to pins for muxing Stephen Warren
2012-02-22 17:21 ` Linus Walleij
2012-02-27 7:11 ` Dong Aisheng
2012-02-27 18:21 ` Stephen Warren
2012-02-20 6:45 ` [PATCH 18/20] pinctrl: Fix pinconf_groups_show() to emit newline Stephen Warren
2012-02-22 17:43 ` Linus Walleij
2012-02-20 6:45 ` [PATCH 19/20] pinctrl: API changes to support multiple states per device Stephen Warren
2012-02-23 5:54 ` Linus Walleij
2012-02-23 16:46 ` Stephen Warren
2012-02-27 9:07 ` Dong Aisheng
2012-02-27 18:37 ` Stephen Warren
2012-02-28 3:18 ` Dong Aisheng
2012-02-28 17:04 ` Stephen Warren
2012-02-29 2:26 ` Dong Aisheng
2012-02-20 6:46 ` [PATCH 20/20] pinctrl: Enhance mapping table to support pin config operations Stephen Warren
2012-02-23 6:08 ` Linus Walleij
2012-02-23 16:48 ` Stephen Warren
2012-02-23 21:13 ` Stephen Warren
2012-02-27 12:21 ` Dong Aisheng
2012-02-27 19:02 ` Stephen Warren
2012-02-28 3:41 ` Dong Aisheng
2012-02-20 21:51 ` [PATCH 00/20] pinctrl: API change, config in mapping table Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222065647.GE11087@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale.com \
--cc=B29396@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dongas86@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@nvidia.com \
--cc=thomas.abraham@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).