From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: mingo@redhat.com, hpa@zytor.com, ananth@in.ibm.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: Re: [tip:perf/core] x86/kprobes: Fix to recover instructions on optimized path
Date: Thu, 23 Feb 2012 09:37:03 +0100 [thread overview]
Message-ID: <20120223083703.GA26781@elte.hu> (raw)
In-Reply-To: <20120223070747.GA14495@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > > Does not build on x86 if CONFIG_OPTPROBES is off:
> > >
> > > arch/x86/kernel/kprobes.c:260:8: error: dereferencing pointer to incomplete type
> > > arch/x86/kernel/kprobes.c:260:8: error: invalid use of undefined type ‘struct optimized_kprobe’
> > > arch/x86/kernel/kprobes.c:262:22: error: dereferencing pointer to incomplete type
> > > arch/x86/kernel/kprobes.c:264:18: error: dereferencing pointer to incomplete type
> >
> > Oops, should I update this patch or send new diff?
>
> Please send a delta fix.
Hm, it was triggering too often so I removed it from perf:core
for now - please send an updated patch.
Please also pick up the slightly updated changelog I've created
for the commit - you can see it in the -tip notification email.
Btw., why are optprobes limited to !PREEMPT, could we make them
preempt safe?
Thanks,
Ingo
next prev parent reply other threads:[~2012-02-23 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 8:36 [PATCH v2 -tip] [BUGFIX] x86/kprobes: Fix to recover instructions on optimized path Masami Hiramatsu
2012-02-22 16:07 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2012-02-22 16:22 ` Ingo Molnar
2012-02-23 1:41 ` Masami Hiramatsu
2012-02-23 7:07 ` Ingo Molnar
2012-02-23 8:37 ` Ingo Molnar [this message]
2012-02-23 14:29 ` Masami Hiramatsu
2012-02-24 9:54 ` [PATCH v3 -tip] [BUGFIX] " Masami Hiramatsu
2012-02-27 9:34 ` Ingo Molnar
2012-02-28 2:52 ` Masami Hiramatsu
2012-02-28 8:48 ` Ingo Molnar
2012-02-28 9:51 ` Masami Hiramatsu
2012-02-28 9:59 ` Ingo Molnar
2012-02-29 13:20 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223083703.GA26781@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).