From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: fix memleak for pci dev removing during hotplug
Date: Thu, 23 Feb 2012 12:10:02 -0800 [thread overview]
Message-ID: <20120223121002.0572b9db@jbarnes-desktop> (raw)
In-Reply-To: <1328948310-14748-1-git-send-email-yinghai@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
On Sat, 11 Feb 2012 00:18:30 -0800
Yinghai Lu <yinghai@kernel.org> wrote:
> unreferenced object 0xffff880276d17700 (size 64):
> comm "swapper/0", pid 1, jiffies 4294897182 (age 3976.028s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 18 f9 de 76 02 88 ff ff ...........v....
> 10 00 00 00 0e 00 00 00 0f 28 40 00 00 00 00 00 .........(@.....
> backtrace:
> [<ffffffff81c8aede>] kmemleak_alloc+0x26/0x43
> [<ffffffff811385f0>] __kmalloc+0x121/0x183
> [<ffffffff813cf821>] pci_add_cap_save_buffer+0x35/0x7c
> [<ffffffff813d12b7>] pci_allocate_cap_save_buffers+0x1d/0x65
> [<ffffffff813cdb52>] pci_device_add+0x92/0xf1
> [<ffffffff81c8afe6>] pci_scan_single_device+0x9f/0xa1
> [<ffffffff813cdbd2>] pci_scan_slot.part.20+0x21/0x106
> [<ffffffff813cdce2>] pci_scan_slot+0x2b/0x35
> [<ffffffff81c8dae4>] __pci_scan_child_bus+0x51/0x107
> [<ffffffff81c8d75b>] pci_scan_bridge+0x376/0x6ae
> [<ffffffff81c8db60>] __pci_scan_child_bus+0xcd/0x107
> [<ffffffff81c8dbab>] pci_scan_child_bus+0x11/0x2a
> [<ffffffff81cca58c>] pci_acpi_scan_root+0x18b/0x21c
> [<ffffffff81c916be>] acpi_pci_root_add+0x1e1/0x42a
> [<ffffffff81406210>] acpi_device_probe+0x50/0x190
> [<ffffffff814a0227>] really_probe+0x99/0x126
>
> Need to free saved_buffer for capabilities.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-23 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 8:18 [PATCH] PCI: fix memleak for pci dev removing during hotplug Yinghai Lu
2012-02-23 20:10 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223121002.0572b9db@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox