From: Wolfram Sang <w.sang@pengutronix.de>
To: Roland Stigge <stigge@antcom.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kevin.wells@nxp.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] USB: Support for LPC32xx SoC
Date: Fri, 24 Feb 2012 07:35:21 +0100 [thread overview]
Message-ID: <20120224063521.GA16412@pengutronix.de> (raw)
In-Reply-To: <4F46AA06.30502@antcom.de>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
> To get rid of the remaining #ifdefs, I could as well create a new
> ohci-lpc32xx.c instead of abusing ohci-pnx4008.c. Would this be the way
> to go or are there any other suggestions?
If you could tell the difference between pnx4008 and lpc32xx, then you could
simply do something like:
if (machine_is_pnx4008)
pnx4008_configure();
else
lpc32xx_configure();
or
if (machine_is_pnx4008)
pnx4008_(un)set_usb_bits
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-24 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 20:57 [PATCH v2] USB: Support for LPC32xx SoC Roland Stigge
2012-02-23 21:05 ` Roland Stigge
2012-02-24 6:35 ` Wolfram Sang [this message]
2012-02-24 15:03 ` Arnd Bergmann
2012-02-25 3:51 ` Wolfram Sang
2012-02-25 8:45 ` Arnd Bergmann
2012-02-25 15:46 ` Alan Stern
2012-02-26 10:01 ` Arnd Bergmann
2012-02-26 15:59 ` Alan Stern
2012-02-27 14:03 ` Arnd Bergmann
2012-02-27 16:42 ` Alan Stern
2012-02-27 22:01 ` Arnd Bergmann
2012-02-28 15:01 ` Alan Stern
2012-02-28 15:53 ` Arnd Bergmann
2012-02-28 16:51 ` Alan Stern
2012-02-25 14:03 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224063521.GA16412@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).