From: Jason Baron <jbaron@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [patch] epoll: remove unneeded variable in reverse_path_check()
Date: Fri, 24 Feb 2012 09:53:24 -0500 [thread overview]
Message-ID: <20120224145323.GA2395@redhat.com> (raw)
In-Reply-To: <20120224113158.GA17641@elgon.mountain>
On Fri, Feb 24, 2012 at 02:31:58PM +0300, Dan Carpenter wrote:
> We never use the length variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index c636fc8..997a6d2 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1042,13 +1042,11 @@ static int reverse_path_check_proc(void *priv, void *cookie, int call_nests)
> */
> static int reverse_path_check(void)
> {
> - int length = 0;
> int error = 0;
> struct file *current_file;
>
> /* let's call this for all tfiles */
> list_for_each_entry(current_file, &tfile_check_list, f_tfile_llink) {
> - length++;
> path_count_init();
> error = ep_call_nested(&poll_loop_ncalls, EP_MAX_NESTS,
> reverse_path_check_proc, current_file,
Yes, I had that in there while testing, and should have removed it.
Acked-by: Jason Baron <jbaron@redhat.com>
Thanks,
-Jason
prev parent reply other threads:[~2012-02-24 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 11:31 [patch] epoll: remove unneeded variable in reverse_path_check() Dan Carpenter
2012-02-24 14:53 ` Jason Baron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224145323.GA2395@redhat.com \
--to=jbaron@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox