From: Greg KH <greg@kroah.com>
To: meng zhang <meng.zhang@mediatek.com>
Cc: smurf@smurf.noris.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces
Date: Fri, 24 Feb 2012 07:40:46 -0800 [thread overview]
Message-ID: <20120224154046.GB16535@kroah.com> (raw)
In-Reply-To: <CACwCHpxjhEenzv+H3zK2cNKAA9KyuK=DPythY2UgHTmY_AhqaQ@mail.gmail.com>
On Fri, Feb 24, 2012 at 02:41:04PM +0800, meng zhang wrote:
> from: Meng Zhang <meng.zhang@mediatek.com>
>
> 1. This patch is based on kernel 3.0.0
That is quite old, please make it against Linus's latest git tree if
possible, and if not, against 3.3-rc4. And if not that, how about 3.3?
> 2. To declare the product IDs in option.c
>
> Signed-off-by: Meng Zhang <meng.zhang@mediatek.com>
> ---------------------------------------------------------------------------------------
>
> --- option.c 2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig 2011-10-07 22:50:04.000000000 +0800
Hm, I think you didn't read Documentation/SubmittingPatches for the
correct patch level to send things. Please fix this as our automated
tools can not handle this patch
> @@ -416,9 +416,6 @@ static void option_instat_callback(struc
> #define SAMSUNG_VENDOR_ID 0x04e8
> #define SAMSUNG_PRODUCT_GT_B3730 0x6889
>
> -/* MediaTek products */
> -#define MEDIATEK_VENDOR_ID 0x0e8d
> -
> /* some devices interfaces need special handling due to a number of reasons */
> enum option_blacklist_reason {
> OPTION_BLACKLIST_NONE = 0,
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */
Your patch is also linewrapped, making it impossible to apply :(
Care to try this again after fixing it?
greg k-h
next prev parent reply other threads:[~2012-02-24 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 6:41 [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces meng zhang
2012-02-24 11:31 ` Sergei Shtylyov
2012-02-24 15:40 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-24 8:04 meng zhang
2012-02-27 4:11 Meng Zhang (张萌)
2012-02-27 11:06 ` Sergei Shtylyov
2012-02-27 11:57 ` Meng Zhang (张萌)
2012-02-27 4:57 Meng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224154046.GB16535@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=meng.zhang@mediatek.com \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox