* Re: coccicheck in 3.3rc1 [not found] <4F1928FC.8090300@inria.fr> @ 2012-01-20 23:10 ` Greg Dietsche 2012-01-20 23:10 ` [PATCH] coccicheck: change handling of C={1,2} when M= is set Greg Dietsche 0 siblings, 1 reply; 6+ messages in thread From: Greg Dietsche @ 2012-01-20 23:10 UTC (permalink / raw) To: Brice.Goglin, julia.lawall, mmarek; +Cc: linux-kernel, Greg Dietsche On 1/20/2012 2:42 AM, Brice Goglin wrote: >I see that reverting d0bc1fb4 makes "make coccicheck M=..." ignore > "M=..." so now I understand the aim of this commit now. I can certainly > switch away from "make C=2 CHECK=scripts/coccicheck M=..." to "make > coccicheck M=...". But I'd like away to get the very basic output back: Hi Brice, Sorry for the trouble. Can you try the patch I've created and see if it works properly when you use "make C=2 CHECK=scripts/coccicheck M=..." ? The patch puts the handling back the way it was for the C=1 and C=2 use case. Also, I've added the LKML Mailing List to the cc so that this patch is posted publicly. Greg Dietsche (1): coccicheck: change handling of C={1,2} when M= is set scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) -- 1.7.6.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] coccicheck: change handling of C={1,2} when M= is set 2012-01-20 23:10 ` coccicheck in 3.3rc1 Greg Dietsche @ 2012-01-20 23:10 ` Greg Dietsche 2012-01-21 7:35 ` Brice Goglin 0 siblings, 1 reply; 6+ messages in thread From: Greg Dietsche @ 2012-01-20 23:10 UTC (permalink / raw) To: Brice.Goglin, julia.lawall, mmarek; +Cc: linux-kernel, Greg Dietsche This patch reverts a portion of d0bc1fb4 so that coccicheck will work properly when C=1 or C=2. Reported-by: Brice Goglin <Brice.Goglin@inria.fr> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> --- scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index 3c27764..823e972 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # FLAGS="-ignore_unknown_options -very_quiet" # OPTIONS=$* - if [ "$KBUILD_EXTMOD" = "" ] ; then - # Workaround for Coccinelle < 0.2.3 - FLAGS="-I $srctree/include -very_quiet" - shift $(( $# - 1 )) - OPTIONS=$1 - else - echo M= is not currently supported when C=1 or C=2 - exit 1 - fi +# Workaround for Coccinelle < 0.2.3 + FLAGS="-I $srctree/include -very_quiet" + shift $(( $# - 1 )) + OPTIONS=$1 else ONLINE=0 FLAGS="-very_quiet" -- 1.7.6.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set 2012-01-20 23:10 ` [PATCH] coccicheck: change handling of C={1,2} when M= is set Greg Dietsche @ 2012-01-21 7:35 ` Brice Goglin 2012-01-21 7:45 ` Julia Lawall 2012-02-22 15:26 ` Brice Goglin 0 siblings, 2 replies; 6+ messages in thread From: Brice Goglin @ 2012-01-21 7:35 UTC (permalink / raw) To: Greg Dietsche; +Cc: julia.lawall, mmarek, linux-kernel Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back. Tested-by: Brice Goglin <Brice.Goglin@inria.fr> Le 21/01/2012 00:10, Greg Dietsche a écrit : > This patch reverts a portion of d0bc1fb4 so that coccicheck will > work properly when C=1 or C=2. > > Reported-by: Brice Goglin <Brice.Goglin@inria.fr> > Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> > --- > scripts/coccicheck | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index 3c27764..823e972 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then > # FLAGS="-ignore_unknown_options -very_quiet" > # OPTIONS=$* > > - if [ "$KBUILD_EXTMOD" = "" ] ; then > - # Workaround for Coccinelle < 0.2.3 > - FLAGS="-I $srctree/include -very_quiet" > - shift $(( $# - 1 )) > - OPTIONS=$1 > - else > - echo M= is not currently supported when C=1 or C=2 > - exit 1 > - fi > +# Workaround for Coccinelle < 0.2.3 > + FLAGS="-I $srctree/include -very_quiet" > + shift $(( $# - 1 )) > + OPTIONS=$1 > else > ONLINE=0 > FLAGS="-very_quiet" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set 2012-01-21 7:35 ` Brice Goglin @ 2012-01-21 7:45 ` Julia Lawall 2012-02-22 15:26 ` Brice Goglin 1 sibling, 0 replies; 6+ messages in thread From: Julia Lawall @ 2012-01-21 7:45 UTC (permalink / raw) To: Brice Goglin Cc: Greg Dietsche, julia.lawall, Michal Marek, mmarek, linux-kernel [-- Attachment #1: Type: TEXT/PLAIN, Size: 1349 bytes --] On Sat, 21 Jan 2012, Brice Goglin wrote: > Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back. > > Tested-by: Brice Goglin <Brice.Goglin@inria.fr> > > > > Le 21/01/2012 00:10, Greg Dietsche a écrit : >> This patch reverts a portion of d0bc1fb4 so that coccicheck will >> work properly when C=1 or C=2. >> >> Reported-by: Brice Goglin <Brice.Goglin@inria.fr> >> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> >> --- >> scripts/coccicheck | 13 ++++--------- >> 1 files changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/scripts/coccicheck b/scripts/coccicheck >> index 3c27764..823e972 100755 >> --- a/scripts/coccicheck >> +++ b/scripts/coccicheck >> @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then >> # FLAGS="-ignore_unknown_options -very_quiet" >> # OPTIONS=$* >> >> - if [ "$KBUILD_EXTMOD" = "" ] ; then >> - # Workaround for Coccinelle < 0.2.3 >> - FLAGS="-I $srctree/include -very_quiet" >> - shift $(( $# - 1 )) >> - OPTIONS=$1 >> - else >> - echo M= is not currently supported when C=1 or C=2 >> - exit 1 >> - fi >> +# Workaround for Coccinelle < 0.2.3 >> + FLAGS="-I $srctree/include -very_quiet" >> + shift $(( $# - 1 )) >> + OPTIONS=$1 >> else >> ONLINE=0 >> FLAGS="-very_quiet" > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set 2012-01-21 7:35 ` Brice Goglin 2012-01-21 7:45 ` Julia Lawall @ 2012-02-22 15:26 ` Brice Goglin 2012-02-24 22:51 ` Michal Marek 1 sibling, 1 reply; 6+ messages in thread From: Brice Goglin @ 2012-02-22 15:26 UTC (permalink / raw) To: Greg Dietsche; +Cc: julia.lawall, mmarek, linux-kernel Unless I missed something, this fix still has not been applied in 3.3-rc. Brice Le 21/01/2012 08:35, Brice Goglin a écrit : > Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back. > > Tested-by: Brice Goglin <Brice.Goglin@inria.fr> > > > > Le 21/01/2012 00:10, Greg Dietsche a écrit : >> This patch reverts a portion of d0bc1fb4 so that coccicheck will >> work properly when C=1 or C=2. >> >> Reported-by: Brice Goglin <Brice.Goglin@inria.fr> >> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> >> --- >> scripts/coccicheck | 13 ++++--------- >> 1 files changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/scripts/coccicheck b/scripts/coccicheck >> index 3c27764..823e972 100755 >> --- a/scripts/coccicheck >> +++ b/scripts/coccicheck >> @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then >> # FLAGS="-ignore_unknown_options -very_quiet" >> # OPTIONS=$* >> >> - if [ "$KBUILD_EXTMOD" = "" ] ; then >> - # Workaround for Coccinelle < 0.2.3 >> - FLAGS="-I $srctree/include -very_quiet" >> - shift $(( $# - 1 )) >> - OPTIONS=$1 >> - else >> - echo M= is not currently supported when C=1 or C=2 >> - exit 1 >> - fi >> +# Workaround for Coccinelle < 0.2.3 >> + FLAGS="-I $srctree/include -very_quiet" >> + shift $(( $# - 1 )) >> + OPTIONS=$1 >> else >> ONLINE=0 >> FLAGS="-very_quiet" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set 2012-02-22 15:26 ` Brice Goglin @ 2012-02-24 22:51 ` Michal Marek 0 siblings, 0 replies; 6+ messages in thread From: Michal Marek @ 2012-02-24 22:51 UTC (permalink / raw) To: Brice Goglin; +Cc: Greg Dietsche, julia.lawall, linux-kernel On Wed, Feb 22, 2012 at 04:26:51PM +0100, Brice Goglin wrote: > Unless I missed something, this fix still has not been applied in 3.3-rc. > Brice > > > > Le 21/01/2012 08:35, Brice Goglin a écrit : > > Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back. > > > > Tested-by: Brice Goglin <Brice.Goglin@inria.fr> I applied it to kbuild.git#rc-fixes now. Michal ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-24 22:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4F1928FC.8090300@inria.fr>
2012-01-20 23:10 ` coccicheck in 3.3rc1 Greg Dietsche
2012-01-20 23:10 ` [PATCH] coccicheck: change handling of C={1,2} when M= is set Greg Dietsche
2012-01-21 7:35 ` Brice Goglin
2012-01-21 7:45 ` Julia Lawall
2012-02-22 15:26 ` Brice Goglin
2012-02-24 22:51 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).