From: David Miller <davem@davemloft.net>
To: baruch@tkos.co.il
Cc: stigge@antcom.de, jeffrey.t.kirsher@intel.com,
alexander.h.duyck@intel.com, eilong@broadcom.com,
ian.campbell@citrix.com, netdev@vger.kernel.org,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org,
kevin.wells@nxp.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver
Date: Sat, 25 Feb 2012 21:28:05 -0500 (EST) [thread overview]
Message-ID: <20120225.212805.1394065389987976077.davem@davemloft.net> (raw)
In-Reply-To: <20120226015217.GA3257@tarshish>
From: Baruch Siach <baruch@tkos.co.il>
Date: Sun, 26 Feb 2012 03:52:18 +0200
> Hi Roland,
>
> On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
>> This patch adds an ethernet driver for the LPC32xx ARM SoC.
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
> [snip]
>
>> +static int __init ethaddr(char *s)
>> +{
>> + int i;
>> + unsigned int r[6];
>> +
>> + sscanf(s, "%x:%x:%x:%x:%x:%x",
>> + &r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
>> + for (i = 0; i < 6; i++)
>> + mac_address[i] = (u8)r[i];
>> +
>> + return 1;
>> +}
>> +__setup("ethaddr=", ethaddr);
>
> Please use a module_param() instead of a top level kernel parameter.
Actually, remove this entirely, we don't add module parameters
to force the ethernet address. That should be done in userland
in some fashion.
We've had many discussions about this recently, and this is the
consistent policy we want to enforce in all drivers from now on.
next prev parent reply other threads:[~2012-02-26 2:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 20:21 [PATCH v2] ARM: LPC32xx: Ethernet driver Roland Stigge
2012-02-25 20:41 ` Joe Perches
2012-02-26 1:52 ` Baruch Siach
2012-02-26 2:28 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 13:08 Roland Stigge
2012-02-28 13:11 ` David Laight
2012-02-28 13:32 ` Roland Stigge
2012-02-28 13:41 ` Arnd Bergmann
2012-02-28 13:49 ` Roland Stigge
2012-02-28 15:53 ` Ben Hutchings
2012-02-28 19:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120225.212805.1394065389987976077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=baruch@tkos.co.il \
--cc=eilong@broadcom.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).