From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: r8712u: Fix regression caused by commit 8c213fa
Date: Sat, 25 Feb 2012 21:49:54 +0300 [thread overview]
Message-ID: <20120225184954.GA4763@mwanda> (raw)
In-Reply-To: <1330190235-511-3-git-send-email-Larry.Finger@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Sat, Feb 25, 2012 at 11:17:15AM -0600, Larry Finger wrote:
> In commit 8c213fa, the command to release the firmware was placed
> in the wrong routine. With NetworkManager, problems were rare, but
> when using wicd as the network control, there is a problem as shown
> in https://bugs.archlinux.org/task/27996#comment89833.
>
This changelog is pretty rubbish.
1) The subject is rubbish.
2) Which commit was 8c213fa? Write it as 8c213fa "staging: r8712u:
Use asynchronous firmware loading". Some of us are really old and
our memory is not good anymore, so we don't know what you're talking
about if you only use the commit id.
3) A link to the bug is good, but please at least put a basic
description of the bug into the changelog itself.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-25 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 17:17 [PATCH 0/2] staging: r8712u: Fix two regressions Larry Finger
2012-02-25 17:17 ` [PATCH 2/2] staging: r8712u: Fix regression caused by commit 8c213fa Larry Finger
2012-02-25 18:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120225184954.GA4763@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).