From: Olof Johansson <olof@lixom.net>
To: Colin Cross <ccross@android.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
Russell King <linux@arm.linux.org.uk>,
Gary King <gking@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/10] ARM: tegra: rework Tegra secondary CPU core bringup
Date: Sun, 26 Feb 2012 13:57:00 -0800 [thread overview]
Message-ID: <20120226215700.GC11189@quad.lixom.net> (raw)
In-Reply-To: <CAMbhsRRkkjfymL=uDt+phM2sLunbypQRUhjZ=DHSO4y9Ko4NJA@mail.gmail.com>
Hi,
On Mon, Feb 20, 2012 at 03:04:57PM -0800, Colin Cross wrote:
> On Thu, Feb 9, 2012 at 3:47 PM, Peter De Schrijver
> <pdeschrijver@nvidia.com> wrote:
> > Prepare the Tegra secondary CPU core bringup code for other Tegra variants.
> > The reset handler is also generalized to allow for future introduction of
> > powersaving modes which turn off the CPU cores.
> >
> > Based on work by:
> >
> > Scott Williams <scwilliams@nvidia.com>
> > Chris Johnson <cwj@nvidia.com>
> > Colin Cross <ccross@android.com>
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> <snip>
>
> > diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
> > index b5349b2..7973f1c 100644
> > --- a/arch/arm/mach-tegra/headsmp.S
> > +++ b/arch/arm/mach-tegra/headsmp.S
>
> <snip>
>
> > @@ -47,15 +64,116 @@ ENTRY(v7_invalidate_l1)
> > mov pc, lr
> > ENDPROC(v7_invalidate_l1)
> >
> > +
> > ENTRY(tegra_secondary_startup)
> > - msr cpsr_fsxc, #0xd3
> > bl v7_invalidate_l1
> > - mrc p15, 0, r0, c0, c0, 5
> > - and r0, r0, #15
> > - ldr r1, =0x6000f100
> > - str r0, [r1]
> > -1: ldr r2, [r1]
> > - cmp r0, r2
> > - beq 1b
> > + mov32 r0, 0xC5ACCE55
> > + mcr p14, 0, r0, c7, c12, 6
>
> One minor nit, you should comment that this is enabling coresight.
Since it's trivial, I did it when I applied the patch here instead of having
Peter respin or add it separately.
-Olof
next prev parent reply other threads:[~2012-02-26 21:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 23:47 [PATCH v3 00/10] Add tegra30 support for secondary cores Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 01/10] ARM: tegra: cleanup use of chipid register Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 02/10] ARM: tegra: export Tegra chipid Peter De Schrijver
2012-02-20 23:13 ` Colin Cross
2012-02-20 23:30 ` Olof Johansson
2012-02-22 19:19 ` Colin Cross
2012-02-09 23:47 ` [PATCH v3 03/10] ARM: tegra: initialize Tegra chipid early Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 04/10] ARM: tegra: functions to access the flowcontroller Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 05/10] ARM: tegra: rework Tegra secondary CPU core bringup Peter De Schrijver
2012-02-20 23:04 ` Colin Cross
2012-02-26 21:57 ` Olof Johansson [this message]
2012-02-09 23:47 ` [PATCH v3 06/10] ARM: tegra: prepare powergate.c for multiple variants Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 07/10] ARM: tegra: export tegra_powergate_is_powered() Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 08/10] ARM: tegra: add support for Tegra30 powerdomains Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 09/10] ARM: tegra: support for Tegra30 CPU powerdomains Peter De Schrijver
2012-02-09 23:47 ` [PATCH v3 10/10] ARM: tegra: support for secondary cores on Tegra30 Peter De Schrijver
2012-02-15 21:27 ` [PATCH v3 00/10] Add tegra30 support for secondary cores Stephen Warren
2012-02-15 22:25 ` Peter De Schrijver
2012-02-29 15:42 ` Peter De Schrijver
2012-02-29 22:38 ` Stephen Warren
2012-03-01 11:42 ` Peter De Schrijver
2012-03-01 14:35 ` Peter De Schrijver
2012-02-26 21:59 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120226215700.GC11189@quad.lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=gking@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox