From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, hughd@google.com, avi@redhat.com,
nate@cpanel.net, cl@linux-foundation.org,
linux-kernel@vger.kernel.org, dpshah@google.com,
ctalbott@google.com, rni@google.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock
Date: Mon, 27 Feb 2012 13:22:20 -0500 [thread overview]
Message-ID: <20120227182220.GD27677@redhat.com> (raw)
In-Reply-To: <20120223231204.GM22536@google.com>
On Thu, Feb 23, 2012 at 03:12:04PM -0800, Tejun Heo wrote:
> On Thu, Feb 23, 2012 at 03:01:23PM -0800, Tejun Heo wrote:
> > Hmmm... going through the thread again, ah, okay, I forgot about that
> > completely. Yeah, that is an actual problem. Both __GFP_WAIT which
> > isn't GFP_KERNEL and GFP_KERNEL are valid use cases. I guess we'll be
> > building async percpu pool in blkcg then. Great. :(
>
> Vivek, you win. :) Can you please refresh the async alloc patch on top
> of blkcg-stacking branch? I'll rool that into this series and drop
> the mempool stuff.
Hi Tejun,
Looks like there is one more issue. After booting kernel, I tried to read
one of the cgroup files.
cat /sys/fs/cgroup/blkio/blkio.throttle.read_bps_device and it oopses.
Basically it looks like that we are getting a null dev pointer while we
do following.
dev_name(blkg->q->backing_dev_info.dev);
I put some printk to verify backing_dev_info.dev is null. That means
somehow we have a request queue and we did not call add_disk() on that?
I checked that queue is not in bypass mode or dead mode. So nobody called
blk_cleanup_queue() on that.
Thanks
Vivek
chilli.lab.bos.redhat.com login: [ 62.090238] Vivek: q =
ffff880136d647a0 bypass=0 dead=0
[ 62.091001] Vivek: dev = ffff880138959520
[ 62.091001] Vivek: q = ffff880136d623d0 bypass=0 dead=0
[ 62.091001] Vivek: dev = (null)
[ 62.091001] BUG: unable to handle kernel NULL pointer dereference at
0000000000000050
[ 62.091001] IP: [<ffffffff813091b5>] blkio_print_group_conf+0x85/0x160
[ 62.091001] PGD 131757067 PUD 130915067 PMD 0
[ 62.091001] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC
[ 62.091001] CPU 2
[ 62.091001] Modules linked in: floppy [last unloaded: scsi_wait_scan]
[ 62.091001]
[ 62.091001] Pid: 4787, comm: cat Tainted: G W
3.3.0-rc3-tejun-misc+ #13 Hewlett-Packard HP xw6600 Workstation/0A9Ch
[ 62.091001] RIP: 0010:[<ffffffff813091b5>] [<ffffffff813091b5>]
blkio_print_group_conf+0x85/0x160
[ 62.091001] RSP: 0018:ffff8801315a9df8 EFLAGS: 00010096
[ 62.091001] RAX: 0000000000000030 RBX: 0000000000000000 RCX:
0000000000006867
[ 62.091001] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
ffffffff81038af5
[ 62.091001] RBP: ffff8801315a9e28 R08: 0000000000000002 R09:
0000000000000000
[ 62.091001] R10: 0000000000000001 R11: 0000000000000000 R12:
0000000000000001
[ 62.091001] R13: 0000000000010000 R14: ffff880137a9b480 R15:
ffff880130a4c248
[ 62.091001] FS: 00007ff3882f6720(0000) GS:ffff88013fc80000(0000)
knlGS:0000000000000000
[ 62.091001] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 62.091001] CR2: 0000000000000050 CR3: 0000000138b0a000 CR4:
00000000000006e0
[ 62.091001] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 62.091001] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
0000000000000400
[ 62.091001] Process cat (pid: 4787, threadinfo ffff8801315a8000, task
ffff8801386ce840)
[ 62.091001] Stack:
[ 62.091001] ffff8801315a9e28 ffff880137a9b7e0 ffffffff81e45fc0
ffff880130a4c248
[ 62.091001] ffffffff81e46aa8 0000000000000000 ffff8801315a9e58
ffffffff813092ff
[ 62.091001] ffff88013167a580 ffff880130a4c248 0000000000000001
ffff88013167a580
[ 62.091001] Call Trace:
[ 62.091001] [<ffffffff813092ff>] blkiocg_file_read+0x6f/0xd0
[ 62.091001] [<ffffffff810aa240>] cgroup_seqfile_show+0x50/0x60
[ 62.091001] [<ffffffff81174741>] seq_read+0x131/0x3f0
[ 62.091001] [<ffffffff8114ee70>] vfs_read+0xb0/0x180
[ 62.091001] [<ffffffff8114ef8a>] sys_read+0x4a/0x90
[ 62.091001] [<ffffffff81843952>] system_call_fastpath+0x16/0x1b
[ 62.091001] Code: 05 48 c1 ea 06 83 e2 01 83 e1 01 e8 dd 51 52 00 48 8b
03 48 c7 c7 57 bc c9 81 48 8b 98 a8 05 00 00 31 c0 48 89 de e8 c2 51 52 00
<48> 8b 53 50 48 85 d2 74 7a 45 85 e4 75 25 41 8b 4e 08 85 c9 75
[ 62.091001] RIP [<ffffffff813091b5>] blkio_print_group_conf+0x85/0x160
[ 62.091001] RSP <ffff8801315a9df8>
[ 62.091001] CR2: 0000000000000050
[ 62.091001] ---[ end trace be53af9706c0e89c ]---
next prev parent reply other threads:[~2012-02-27 18:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:30 [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock Tejun Heo
2012-02-23 22:30 ` [PATCH 1/8] mempool: factor out mempool_fill() Tejun Heo
2012-02-23 22:30 ` [PATCH 2/8] mempool: separate out __mempool_create() Tejun Heo
2012-02-23 22:30 ` [PATCH 3/8] mempool, percpu: implement percpu mempool Tejun Heo
2012-02-23 22:30 ` [PATCH 4/8] block: fix deadlock through percpu allocation in blk-cgroup Tejun Heo
2012-02-23 22:30 ` [PATCH 5/8] blkcg: don't use percpu for merged stats Tejun Heo
2012-02-23 22:30 ` [PATCH 6/8] blkcg: simplify stat reset Tejun Heo
2012-02-23 22:30 ` [PATCH 7/8] blkcg: restructure blkio_get_stat() Tejun Heo
2012-02-23 22:30 ` [PATCH 8/8] blkcg: remove blkio_group->stats_lock Tejun Heo
2012-02-23 22:43 ` [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock Andrew Morton
2012-02-23 23:01 ` Tejun Heo
2012-02-23 23:12 ` Tejun Heo
2012-02-23 23:22 ` Andrew Morton
2012-02-23 23:24 ` Tejun Heo
2012-02-24 14:20 ` Vivek Goyal
2012-02-25 21:44 ` Tejun Heo
2012-02-27 3:11 ` Vivek Goyal
2012-02-27 9:11 ` Tejun Heo
2012-02-27 19:43 ` Vivek Goyal
2012-02-29 17:36 ` Vivek Goyal
2012-03-05 22:13 ` Tejun Heo
2012-03-06 21:09 ` Vivek Goyal
2012-03-06 21:20 ` Andrew Morton
2012-03-06 21:34 ` Vivek Goyal
2012-03-06 21:55 ` Andrew Morton
2012-03-07 14:55 ` Vivek Goyal
2012-03-07 17:05 ` Tejun Heo
2012-03-07 19:13 ` Vivek Goyal
2012-03-07 19:22 ` Tejun Heo
2012-03-07 19:42 ` Vivek Goyal
2012-03-07 22:56 ` Tejun Heo
2012-03-07 23:08 ` Andrew Morton
2012-03-07 23:15 ` Tejun Heo
2012-03-07 23:05 ` Andrew Morton
2012-03-08 17:57 ` Vivek Goyal
2012-03-08 18:08 ` Tejun Heo
2012-03-08 18:11 ` Tejun Heo
2012-03-08 18:22 ` Vivek Goyal
2012-03-08 18:27 ` Tejun Heo
2012-03-15 16:48 ` Vivek Goyal
2012-03-15 16:59 ` Tejun Heo
2012-03-20 11:50 ` Jens Axboe
2012-03-08 20:16 ` Vivek Goyal
2012-03-08 20:33 ` Vivek Goyal
2012-03-08 20:35 ` Tejun Heo
2012-03-08 19:06 ` Andrew Morton
2012-02-25 3:44 ` Vivek Goyal
2012-02-25 21:46 ` Tejun Heo
2012-02-25 22:21 ` Tejun Heo
2012-02-27 14:25 ` Vivek Goyal
2012-02-27 14:40 ` Vivek Goyal
2012-03-05 17:45 ` Tejun Heo
2012-02-27 18:22 ` Vivek Goyal [this message]
2012-02-29 19:03 ` Vivek Goyal
2012-03-05 17:20 ` Tejun Heo
2012-03-05 18:03 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227182220.GD27677@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=axboe@kernel.dk \
--cc=cl@linux-foundation.org \
--cc=ctalbott@google.com \
--cc=dpshah@google.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nate@cpanel.net \
--cc=rni@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).