public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Autif Khan <autifk@gmail.com>
Cc: rusty@rustcorp.com.au, jhovold@gmail.com,
	stern@rowland.harvard.edu, mchehab@redhat.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers: usb: serial: sierra - upgrade to 1.7.40
Date: Tue, 28 Feb 2012 08:53:22 -0800	[thread overview]
Message-ID: <20120228165322.GB11133@kroah.com> (raw)
In-Reply-To: <1330447152-5770-1-git-send-email-autifk@gmail.com>

On Tue, Feb 28, 2012 at 11:39:12AM -0500, Autif Khan wrote:
> driver was upgraded from 1.7.16 to 1.7.40
> source of the driver at the time of this change:
> http://www.sierrawireless.com/resources/support/drivers/linux/v3.2_1740_kernel-3.0.directIP.tar
> 
> The driver compiles (monolithic and module)
> I have not tested it on any device

I need reasons for this update.  What changed, and why is what we need
to know.  No "wholesale" upgrade of a file is allowed, you need to break
the changes up into logical pieces, and send them with a proper
description of what happened here.

Also, please cc: and properly credit the original authors of these
changes, and the maintainer of the driver, to give them a chance to
review it.

So, sorry, I can't take these 3 patches unless they are broken up
properly, and I would like to get an ack from the driver
maintainer/author.

thanks,

greg k-h

      reply	other threads:[~2012-02-28 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 16:39 [PATCH 1/3] drivers: usb: serial: sierra - upgrade to 1.7.40 Autif Khan
2012-02-28 16:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228165322.GB11133@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=autifk@gmail.com \
    --cc=jhovold@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox