From: Stephen Hemminger <shemminger@vyatta.com>
To: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mcgrof@frijolero.org>,
<qca-linux-team@qualcomm.com>, <nic-devel@qualcomm.com>,
<kgiori@qca.qualcomm.com>, <chris.snook@gmail.com>,
<mathieu@qca.qualcomm.com>, <bryanh@quicinc.com>
Subject: Re: [PATCH] net: add QCA alx Ethernet driver
Date: Tue, 28 Feb 2012 19:32:37 -0800 [thread overview]
Message-ID: <20120228193237.2d56f2b8@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1330480210-30470-1-git-send-email-rodrigue@qca.qualcomm.com>
On Tue, 28 Feb 2012 17:50:09 -0800
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com> wrote:
> From: Luis R. Rodriguez <mcgrof@frijolero.org>
>
> The next patch adds the new QCA alx Ethernet driver that
> supercedes the atl1c Ethernet driver. For details please
> read the commit log of the patch. Given the size you can
> download the patch from:
>
> http://bombadil.infradead.org/~mcgrof/2012/02/28/add-alx-next-20120228.patch
> sha1sum: 8a8f7b6f1cbe737e70ec3b3eda483a6925fd9bd6
Evolution is better. The new driver has lots of new callbacks to handle
the fact it is dealing with two different chipsets. Not only that your callbacks
are built at runtime which leads to security concerns.
There is a reason the two Marvell based drivers (skge and sky2) are
different drivers. Having to do extra per-chip callbacks is a clear sign
the driver should be split in two.
next prev parent reply other threads:[~2012-02-29 3:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 1:50 [PATCH] net: add QCA alx Ethernet driver Luis R. Rodriguez
2012-02-29 1:50 ` [PATCH] net: add new QCA alx ethernet driver which supercedes atl1c Luis R. Rodriguez
2012-02-29 1:58 ` David Miller
2012-02-29 1:53 ` [PATCH] net: add QCA alx Ethernet driver David Miller
2012-02-29 2:12 ` Luis R. Rodriguez
2012-02-29 2:15 ` David Miller
2012-02-29 2:19 ` Huang, Xiong
2012-02-29 2:28 ` David Miller
2012-02-29 3:11 ` Huang, Xiong
2012-02-29 3:32 ` David Miller
2012-02-29 7:30 ` Huang, Xiong
2012-02-29 9:38 ` Luis R. Rodriguez
2012-03-22 1:28 ` Luis R. Rodriguez
2012-03-22 9:27 ` Francois Romieu
2012-03-22 13:38 ` Luis R. Rodriguez
2012-03-30 17:10 ` Luis R. Rodriguez
2012-03-30 20:45 ` David Miller
2012-03-30 20:52 ` Luis R. Rodriguez
2012-02-29 3:32 ` Stephen Hemminger [this message]
2012-03-01 23:40 ` Francois Romieu
2012-03-02 0:56 ` Joe Perches
2012-02-29 3:52 ` Joe Perches
[not found] ` <CAA93jw4NwHaLazxK2Eo6a6TuvF3svqdZjTpHUwOyEHv-Q=busQ@mail.gmail.com>
2012-03-30 18:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228193237.2d56f2b8@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bryanh@quicinc.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu@qca.qualcomm.com \
--cc=mcgrof@frijolero.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox