From: Felipe Balbi <balbi@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Felipe Balbi <balbi@ti.com>, Jiri Kosina <trivial@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH trivial next 9/9] gadget: Use vsprintf extention %pf with builtin_return_address
Date: Tue, 28 Feb 2012 21:39:07 +0200 [thread overview]
Message-ID: <20120228193906.GA891@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1bc7879deffd667985a3bcfce70e19418c704143.1330454853.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On Tue, Feb 28, 2012 at 10:49:38AM -0800, Joe Perches wrote:
> Emit the function name not the address when possible.
>
> builtin_return_address() gives an address. When building
> a kernel with CONFIG_KALLSYMS, emit the actual function
> name not the address.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/usb/gadget/u_serial.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index 6597a68..a553bee 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -920,7 +920,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
> unsigned long flags;
> int status;
>
> - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %p\n",
> + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> port->port_num, tty, ch, __builtin_return_address(0));
>
> spin_lock_irqsave(&port->port_lock, flags);
> --
> 1.7.8.111.gad25c.dirty
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-28 19:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 18:49 [PATCH trivial next 0/9] treewide: Use vsprintf extention %pf Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 1/9] sparc: Use vsprintf extention %pf with builtin_return_address Joe Perches
2012-02-28 21:08 ` David Miller
2012-02-28 18:49 ` [PATCH trivial next 2/9] alpha: " Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 3/9] arm: " Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 4/9] microblaze: " Joe Perches
2012-03-13 8:24 ` Michal Simek
2012-02-28 18:49 ` [PATCH trivial next 5/9] powerpc: " Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 6/9] parisc: " Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 7/9] scsi: " Joe Perches
2012-02-28 21:07 ` David Miller
2012-02-28 18:49 ` [PATCH trivial next 8/9] staging: ramster: " Joe Perches
2012-02-28 18:49 ` [PATCH trivial next 9/9] gadget: " Joe Perches
2012-02-28 19:39 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228193906.GA891@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).