Re: [PATCH 1/3] mce: Add a msg string to the MCE tracepoint

[Borislav Petkov <bp@amd64.org>]

On Wed, Feb 29, 2012 at 10:05:53AM -0300, Mauro Carvalho Chehab wrote:
> Em 29-02-2012 09:19, Borislav Petkov escreveu:
> > On Wed, Feb 29, 2012 at 09:04:46AM -0300, Mauro Carvalho Chehab wrote:
> >> Not all information is packed in the record. The record packs only what it
> >> is inside the MCE registers. However, for certain errors, it is needed to
> >> parse other hardware registers to decode the error (for example, on Sandy
> >> Bridge, the MCE registers don't contain the affected dimms).
> > 
> > If SB is not using MCA to report the error, it should use either a
> > generic TP like the trace_hw_error() example I gave last week, or rather
> > a TP which matches the hw registers of the reporting hardware scheme.
> 
> This is not what I said. On intel, both SB and Nehalem use MCA to report errors.
> Older chipsets don't use MCA.
> 
> However, there's a fundamental difference between SB and Nehalem:
> 
> - on Nehalem, the MCE status register encodes not only the error message; it
>   also encodes the DIMM that generated the  error. So, it is possible to 
>   completely decode the error on userspace, using only the MCE registers.

Well, depending on what Tony wants to do there, either decode the error
in the kernel and pass it on with the 'msg' arg or do the whole decoding
in userspace.

> - on SB, the MCE status register only has the error message. In order to get
>   the DIMM location, the driver needs to parse the registers that describe
>   how the DIMM's are organized (this is spread on dozens of PCI devices, and
>   200+ registers), and how they're interlaced, in order to convert the error 
>   address reported by the MCA into a DIMM location.

As I already said, amd64_edac does a similar thing does already so I
don't see any difference in the solutions there: decode to the DIMM and
pass the info through 'msg'.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551