From: Wolfram Sang <w.sang@pengutronix.de>
To: Oskar Schirmer <oskar@scara.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Darius Augulis <augulis.darius@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH] i2c/imx: fix imx driver to work though signal is pending
Date: Wed, 29 Feb 2012 20:06:21 +0100 [thread overview]
Message-ID: <20120229190621.GD30545@pengutronix.de> (raw)
In-Reply-To: <1329999551-32171-1-git-send-email-oskar@scara.com>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Thu, Feb 23, 2012 at 12:19:11PM +0000, Oskar Schirmer wrote:
> Interrupt a test application for I2C based mc13xxx driven
> touch panel, SIGINT, causes open event file descriptor to be
> closed, which in turn causes I2C activity to mask PMIC local
> interrupts. This eventually ends up in i2c_imx_bus_busy to
> wait for some busy flag to toggle, but while waiting it would
> find a signal pending and break. The final symptom is the
> device is not closed down cleanly and thus not reopenable.
>
> Do without check for pending signal.
>
> Signed-off-by: Oskar Schirmer <oskar@scara.com>
Thanks. Picked to my for-3.4 branch. I'd like to have some more test coverage,
then we can send it back via a stable-release. If you think it should go into
3.3 directly, please let me know.
Oh, and it got acked by Marc Kleine-Budde via phone :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-02-29 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 12:19 [PATCH] i2c/imx: fix imx driver to work though signal is pending Oskar Schirmer
2012-02-29 19:06 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229190621.GD30545@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=augulis.darius@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=oskar@scara.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).