public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Matthew Garrett <mjg@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: Add driver for Apple gmux device
Date: Wed, 29 Feb 2012 13:50:42 -0600	[thread overview]
Message-ID: <20120229195042.GB20565@ubuntu-macmini> (raw)
In-Reply-To: <CACxGe6uc+LZjuMLS5DZELzAsHsnhObL6mdPzdMnNVbfriTfNwg@mail.gmail.com>

On Wed, Feb 29, 2012 at 12:43:23PM -0600, Grant Likely wrote:
> On Wed, Feb 29, 2012 at 11:53 AM, Seth Forshee
> <seth.forshee@canonical.com> wrote:
> > On Wed, Feb 29, 2012 at 11:46:39AM -0600, Grant Likely wrote:
> >> On Wed, Feb 22, 2012 at 8:37 AM, Seth Forshee
> >> <seth.forshee@canonical.com> wrote:
> >> > Apple laptops with hybrid graphics have a device named gmux that
> >> > controls the muxing of the LVDS panel between the GPUs as well as screen
> >> > brightness. This driver adds support for the gmux device. Only backlight
> >> > control is supported initially.
> >> >
> >> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> >>
> >> Works for me.
> >>
> >> Tested-by: Grant Likely <grant.likely@secretlab.ca>
> >>
> >> Now I just need to figure out how to get the desktop backlight widget
> >> to use gmux_backlight instead of acpi_video0...
> >
> > The easy way is to pass acpi_backlight=vendor to the kernel, then you
> > won't have acpi_vidoe0.
> 
> That did it, thanks.  I'm assume something is in the works to set it
> up automatically?

Not that I'm aware of. A number machines have this problem, that the
standard ACPI backlight interfaces are implemented but don't work. This
generally isn't detectable in software; with the Apples at least
everything looks like it's working except that the brightness doesn't
change (but not all Apple laptops are affected, so qurking based on
manufacturer wouldn't work). All we're left with is DMI quirking, which
isn't practical. Maybe we could add something so a platform driver can
tell acpi_video that it knows the ACPI backlight doesn't work, but I
think on some platforms that still is going to be based off of DMI
information.

What about userspace? I don't know about other desktops, but in the past
gnome-settings-daemon had a list to determine which backlight to prefer,
so it would have been possible to insert gmux_backlight in the list
above acpi_video0. It seems to have been changed now to use the
backlight type, preferring a firmware backlight to a platform one, which
would prefer acpi_video0 to gmux_backlight. I don't know know what the
solution is under this paradigm.

Seth

  reply	other threads:[~2012-02-29 19:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 20:34 [PATCH] platform/x86: Add driver for Apple gmux device Seth Forshee
2012-02-22 14:37 ` [PATCH v2] " Seth Forshee
2012-02-29 17:46   ` Grant Likely
2012-02-29 17:53     ` Seth Forshee
2012-02-29 18:43       ` Grant Likely
2012-02-29 19:50         ` Seth Forshee [this message]
2012-02-29 21:23           ` Grant Likely
2012-02-29 22:08             ` Seth Forshee
2012-02-29 22:32               ` Grant Likely
2012-02-29 22:56                 ` Seth Forshee
2012-03-01  9:19                   ` Corentin Chary
2012-03-01 14:53                     ` Seth Forshee
2012-03-01 15:15                       ` Corentin Chary
2012-03-05 22:06   ` Seth Forshee
2012-03-05 22:10     ` Josh Boyer
2012-03-05 22:37       ` Seth Forshee
2012-03-06 12:52         ` Josh Boyer
2012-03-12 14:21   ` Matthew Garrett
2012-03-12 14:57     ` Seth Forshee
2012-03-12 15:07       ` Matthew Garrett
2012-03-12 15:18         ` Seth Forshee
2012-03-12 15:22           ` Matthew Garrett
2012-03-12 15:40             ` Seth Forshee
2012-03-15 15:47         ` Seth Forshee
2012-03-15 16:09           ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120229195042.GB20565@ubuntu-macmini \
    --to=seth.forshee@canonical.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox