From: Nick Bowler <nbowler@elliptictech.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Eric Andersson <eric.andersson@unixphere.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
christoph.mair@gmail.com, stefan.nilsson@unixphere.com,
zhengguang.guo@bosch-sensortec.com, peter.moeller@cn.bosch.com,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 0/3] Replace bmp085 with bmp18x
Date: Wed, 29 Feb 2012 15:37:43 -0500 [thread overview]
Message-ID: <20120229203743.GA21671@elliptictech.com> (raw)
In-Reply-To: <201202292018.45557.arnd@arndb.de>
On 2012-02-29 20:18 +0000, Arnd Bergmann wrote:
> On Wednesday 29 February 2012, Eric Andersson wrote:
> > This patch-set replaces the BMP085 driver with a driver for Bosch Sensortec's new
> > generation of pressure sensors called BMP18x. These pressure sensors can be
> > connected on I2C but also on SPI as a variant, so the driver implements both.
> > Register-wise they are fully compatible with the older BMP085, so the driver will
> > support those chips as well.
> >
> > The driver is based on bmp085.c by Christoph Mair.
>
> Hmm, the implementation looks fine, but I don't think we should add support
> for new devices with a one-off interface that we know is getting replaced by
> something generic.
Notwithstanding the value of using newer generic interfaces, from what I
can tell, there are no new sysfs attributes added by this driver over
the one it replaces. If this driver is going to supersede the old one,
it has to retain the existing interface. Otherwise, we must keep both
drivers in the tree to avoid regressions.
> Why is this not using IIO for its user interface?
Because IIO is currently in staging, and this driver is not?
Cheers,
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2012-02-29 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 19:58 [PATCH 0/3] Replace bmp085 with bmp18x Eric Andersson
2012-02-29 19:58 ` [PATCH 1/3] drivers/misc: add support for BMP18x pressure sensors Eric Andersson
2012-03-01 0:11 ` Alan Cox
2012-02-29 19:58 ` [PATCH 2/3] Documentation: add sysfs ABI documentation for bmp18x Eric Andersson
2012-02-29 19:58 ` [PATCH 3/3] drivers/misc: remove bmp085 driver Eric Andersson
2012-02-29 20:18 ` [PATCH 0/3] Replace bmp085 with bmp18x Arnd Bergmann
2012-02-29 20:37 ` Nick Bowler [this message]
2012-02-29 21:26 ` Arnd Bergmann
2012-03-01 13:19 ` Eric Andersson
2012-02-29 21:19 ` Eric Andersson
2012-02-29 23:52 ` Alan Cox
2012-03-02 16:49 ` Arnd Bergmann
2012-03-02 17:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229203743.GA21671@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=arnd@arndb.de \
--cc=christoph.mair@gmail.com \
--cc=eric.andersson@unixphere.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.moeller@cn.bosch.com \
--cc=stefan.nilsson@unixphere.com \
--cc=zhengguang.guo@bosch-sensortec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox