From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Blanchard <anton@samba.org>
Cc: benh@kernel.crashing.org, paulus@samba.org, asharma@fb.com,
vapier@gentoo.org, eric.dumazet@gmail.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Richard Kuo <rkuo@codeaurora.org>,
linux-hexagon@vger.kernel.org
Subject: Re: [PATCH 1/2] atomic: Allow atomic_inc_not_zero to be overridden
Date: Thu, 1 Mar 2012 15:02:56 -0800 [thread overview]
Message-ID: <20120301150256.9a7d0b06.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120301180953.0f61576f@kryten>
On Thu, 1 Mar 2012 18:09:53 +1100
Anton Blanchard <anton@samba.org> wrote:
>
> We want to implement a ppc64 specific version of atomic_inc_not_zero
> so wrap it in an ifdef to allow it to be overridden.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> Index: linux-build/include/linux/atomic.h
> ===================================================================
> --- linux-build.orig/include/linux/atomic.h 2012-02-11 14:59:23.284714257 +1100
> +++ linux-build/include/linux/atomic.h 2012-02-11 15:01:14.894764555 +1100
> @@ -24,7 +24,9 @@ static inline int atomic_add_unless(atom
> * Atomically increments @v by 1, so long as @v is non-zero.
> * Returns non-zero if @v was non-zero, and zero otherwise.
> */
> +#ifndef atomic_inc_not_zero
> #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
> +#endif
Please merge this via the ppc tree?
And let's ask the hexagon maintainers to take a look at the definition
in arch/hexagon/include/asm/atomic.h. I assume that it can be removed,
but that might cause problems with files which include asm/atomic.h
directly. I have found two such files in non-arch code and have queued
fixes. There are no such files in arch/hexagon code, so I think it's
safe to zap the hexagon definition of atomic_inc_not_zero().
> +static __inline__ int atomic_inc_not_zero(atomic_t *v)
Curious: is there a technical reason why ppc uses "__inline__" rather
than "inline"?
next prev parent reply other threads:[~2012-03-01 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 7:09 [PATCH 1/2] atomic: Allow atomic_inc_not_zero to be overridden Anton Blanchard
2012-03-01 7:12 ` [PATCH 2/2] powerpc: atomic: Implement atomic*_inc_not_zero Anton Blanchard
2012-03-01 17:19 ` [PATCH 1/2] atomic: Allow atomic_inc_not_zero to be overridden Mike Frysinger
2012-03-01 23:02 ` Andrew Morton [this message]
2012-03-01 23:48 ` Richard Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301150256.9a7d0b06.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=asharma@fb.com \
--cc=benh@kernel.crashing.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rkuo@codeaurora.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox