linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini@gnudd.com>
To: linus.walleij@linaro.org
Cc: linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
	alan@linux.intel.com, sameo@linux.intel.com,
	grant.likely@secretlab.ca, linus.walleij@stericsson.com
Subject: Re: [PATCH V2 2/2] gpio: add STA2X11 GPIO block
Date: Thu, 1 Mar 2012 19:50:35 +0100	[thread overview]
Message-ID: <20120301185035.GA25359@mail.gnudd.com> (raw)
In-Reply-To: <CACRpkdaL=f7A6se63yXO=bwySC_S2yRd4r3AEfTAy6YtGi5-CQ@mail.gmail.com>

>> +       if (cfg == PINMUX_TYPE_FUNCTION) {
> (...)
>> +       case PINMUX_TYPE_OUTPUT_LOW:
> (...)
>> +       case PINMUX_TYPE_OUTPUT_HIGH:
> (...)
>> +       case PINMUX_TYPE_INPUT:
> (...)
>> +       case PINMUX_TYPE_INPUT_PULLUP:
> (...)
>> +       case PINMUX_TYPE_INPUT_PULLDOWN:
> 
> We have created the pin control subsystem to handle things like
> this. (Muxing and complex control.)
> 
> Please create a driver in drivers/pinctrl/pinctrl-sta2x11.c that
> expose both a pinctrl and a GPIOlib interface. The GPIOlib
> interface can call into the pin control portions just fine.

I'm sorry, after digging in it for a while I'm really lost.  This
pinctrl file should be there _instead_ of the gpio file or in addition
to it?  I see tegra has both, but u300 has only one.

Also, this pinctrl depends on CONFIG_EXPERIMENTAL at this point in time.
Is it wise the make the whole sta2x11 thing depend on experimental?

Thanks
/alessandro

  parent reply	other threads:[~2012-03-01 18:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 13:00 [PATCH V2 0/2] MFD and GPIO for STA2X11 Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block Alessandro Rubini
2012-02-16 19:29   ` Linus Walleij
2012-02-23 16:19   ` Samuel Ortiz
2012-02-23 16:25   ` Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 2/2] gpio: add STA2X11 GPIO block Alessandro Rubini
2012-02-16 19:16   ` Linus Walleij
2012-02-16 19:24   ` Linus Walleij
2012-02-16 20:24   ` Alessandro Rubini
2012-02-16 20:24   ` Alessandro Rubini
2012-03-01 18:50   ` Alessandro Rubini [this message]
2012-03-01 20:20     ` Linus Walleij
2012-03-02  7:48   ` Grant Likely
2012-03-02 10:00   ` Alessandro Rubini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120301185035.GA25359@mail.gnudd.com \
    --to=rubini@gnudd.com \
    --cc=alan@linux.intel.com \
    --cc=giancarlo.asnaghi@st.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).