Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three

Yinghai Lu
2012-03-01T19:19:11Z

On Thu, Mar 1, 2012 at 11:03 AM, Sarah Sharp
<sarah.a.sharp@linux.intel.com> wrote:
> On Thu, Mar 01, 2012 at 09:24:35AM -0800, Greg Kroah-Hartman wrote:
>> On Thu, Mar 01, 2012 at 09:17:07AM -0800, Yinghai Lu wrote:
>> > so we avoid checking class again and again in that quirk.
>> >
>> > need to be applied after pci/linux-next and usb/usb-next
>>
>> As those are two independant trees, this needs to wait until after
>> 3.4-rc1 is out.
>>
>> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>> >
>> > ---
>> >  drivers/usb/host/pci-quirks.c |   42 ++++++++++++++++++++++++++++--------------
>> >  1 file changed, 28 insertions(+), 14 deletions(-)
>>
>> Is this really helping anything here?  You added code overall :(
>
> I agree with Greg.  Why change this?  Does it shave off any boot time?
> Please show hard numbers for what improvements this makes.  I really
> don't want to change PCI init and break people's systems.

but your code make pci init change to call disable/enable for non-xhci
for fixing xhci problem.

| commit cab928ee1f221c9cc48d6615070fefe2e444384a
| Author: Sarah Sharp <sarah.a.sharp@linux.intel.com>
| Date: Tue Feb 7 15:11:46 2012 -0800
|
| USB: Fix handoff when BIOS disables host PCI device.

Yinghai