Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three

Sarah Sharp
2012-03-01T20:08:55Z

On Thu, Mar 01, 2012 at 11:19:06AM -0800, Yinghai Lu wrote:
> On Thu, Mar 1, 2012 at 11:03 AM, Sarah Sharp
> <sarah.a.sharp@linux.intel.com> wrote:
> > On Thu, Mar 01, 2012 at 09:24:35AM -0800, Greg Kroah-Hartman wrote:
> >> On Thu, Mar 01, 2012 at 09:17:07AM -0800, Yinghai Lu wrote:
> >> > so we avoid checking class again and again in that quirk.
> >> >
> >> > need to be applied after pci/linux-next and usb/usb-next
> >>
> >> As those are two independant trees, this needs to wait until after
> >> 3.4-rc1 is out.
> >>
> >> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >> >
> >> > ---
> >> >  drivers/usb/host/pci-quirks.c |   42 ++++++++++++++++++++++++++++--------------
> >> >  1 file changed, 28 insertions(+), 14 deletions(-)
> >>
> >> Is this really helping anything here?  You added code overall :(
> >
> > I agree with Greg.  Why change this?  Does it shave off any boot time?
> > Please show hard numbers for what improvements this makes.  I really
> > don't want to change PCI init and break people's systems.
>
> but your code make pci init change to call disable/enable for non-xhci
> for fixing xhci problem.

We discussed this, and agreed it was safe to do so for all USB host
controllers. It's possible some other BIOS will disable the PCI host
controller before handing it off to the OS, so we have to handle that
case. So it's fine that we enable/disable the device for all USB host
controllers. I tried to make sure we weren't enabling/disabling for
non-USB PCI devices.

Sarah Sharp