Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three

Yinghai Lu
2012-03-01T19:20:36Z

On Thu, Mar 1, 2012 at 10:20 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:

> Hmm...  From the description, I thought this patch only took advantage
> of DECLARE_PCI_FIXUP_CLASS_FINAL to remove the "if (pdev->class ==
> XXX)" tests.
>
> If it *also* skips a disable/enable sequence on non-xhci controllers,
> please make that a separate patch so it's clear what's happening.
>
> It's very important to be clear about these things for people who are
> deciding whether to backport patches into distros.  All the zillions
> of PCI changes we're doing make their lives hard enough without having
> subtle behavior changes hidden in patches that seem to be "code
> restructure only, no behavior change."

sure, will separate the patch to small ones.

Thanks

Yinghai