From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899Ab2CAXaV (ORCPT ); Thu, 1 Mar 2012 18:30:21 -0500 Received: from li9-11.members.linode.com ([67.18.176.11]:58863 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111Ab2CAXaR (ORCPT ); Thu, 1 Mar 2012 18:30:17 -0500 Date: Thu, 1 Mar 2012 18:29:42 -0500 From: "Ted Ts'o" To: Jan Kara Cc: Andrew Morton , linux-mm@kvack.org, LKML , Al Viro , linux-fsdevel@vger.kernel.org, dchinner@redhat.com, Jaya Kumar , Sage Weil , ceph-devel@vger.kernel.org, Steve French , linux-cifs@vger.kernel.org, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net, Miklos Szeredi , fuse-devel@lists.sourceforge.net, Steven Whitehouse , cluster-devel@redhat.com, Greg Kroah-Hartman Subject: Re: [PATCH 00/11 v2] Push file_update_time() into .page_mkwrite Message-ID: <20120301232942.GH32588@thunk.org> Mail-Followup-To: Ted Ts'o , Jan Kara , Andrew Morton , linux-mm@kvack.org, LKML , Al Viro , linux-fsdevel@vger.kernel.org, dchinner@redhat.com, Jaya Kumar , Sage Weil , ceph-devel@vger.kernel.org, Steve French , linux-cifs@vger.kernel.org, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net, Miklos Szeredi , fuse-devel@lists.sourceforge.net, Steven Whitehouse , cluster-devel@redhat.com, Greg Kroah-Hartman References: <1330602103-8851-1-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330602103-8851-1-git-send-email-jack@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on test.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 01, 2012 at 12:41:34PM +0100, Jan Kara wrote: > > To fix the issue, this patch set changes page fault code to call > file_update_time() only when ->page_mkwrite() callback is not provided. If the > callback is provided, it is the responsibility of the filesystem to perform > update of i_mtime / i_ctime if needed. We also push file_update_time() call > to all existing ->page_mkwrite() implementations if the time update does not > obviously happen by other means. If you know your filesystem does not need > update of modification times in ->page_mkwrite() handler, please speak up and > I'll drop the patch for your filesystem. I don't know if this introductory text is going to be saved anywhere permanent, such as the merge commit (since git now has the ability to have much more informative merge descriptions). But if it is going to be preserved, it might be worth mentioning that if the filesystem uses block_page_mkpage(), it will handled automatically for them since the patch series does push the call to file_update_time(0 into __block_page_mkpage(). - Ted