From: Alessandro Rubini <rubini@gnudd.com>
To: grant.likely@secretlab.ca
Cc: linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
alan@linux.intel.com, sameo@linux.intel.com,
linus.walleij@stericsson.com
Subject: Re: [PATCH V2 2/2] gpio: add STA2X11 GPIO block
Date: Fri, 2 Mar 2012 11:00:12 +0100 [thread overview]
Message-ID: <20120302100012.GA31314@mail.gnudd.com> (raw)
In-Reply-To: <20120302074800.C2F973E17BE@localhost>
Thank you Grant for your comments. Agreed with all of them.
>> + /* 384 was used in previous code: be compatible for other drivers */
>> + err = irq_alloc_descs(-1, 384, GSTA_NR_GPIO, NUMA_NO_NODE);
>
> That's a lot of irqs. Will they all be used?
384 is the starting point, isn't it? The number is 128. One per gpio pin.
We have change-detect for mmc and other stuff that live in high gpio
numbers.
> How do other drivers determine which irq number to use (is it
> statically assigned, or is there a dynamic mechanism)? If only a
> portion are used, then the irq_domain linear mapping would be a win
> here.
The code I received uses static numbers. The chip is the main chipset
in the typical use case, so only one is there even if it is PCI. I
also have a PCIe card to use it as slave device, and I'm careful to
allow several of them, even if it's not the main use case. Maybe here
I fell short. I'm reposting soon, with a full change log.
This "compatibility" is something I need to run the boards with
existing code for the parts that are not cleaned up for upstream, yet.
/alessandro
prev parent reply other threads:[~2012-03-02 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:00 [PATCH V2 0/2] MFD and GPIO for STA2X11 Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block Alessandro Rubini
2012-02-16 19:29 ` Linus Walleij
2012-02-23 16:19 ` Samuel Ortiz
2012-02-23 16:25 ` Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 2/2] gpio: add STA2X11 GPIO block Alessandro Rubini
2012-02-16 19:16 ` Linus Walleij
2012-02-16 19:24 ` Linus Walleij
2012-02-16 20:24 ` Alessandro Rubini
2012-02-16 20:24 ` Alessandro Rubini
2012-03-01 18:50 ` Alessandro Rubini
2012-03-01 20:20 ` Linus Walleij
2012-03-02 7:48 ` Grant Likely
2012-03-02 10:00 ` Alessandro Rubini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302100012.GA31314@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).