* [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator
@ 2012-03-02 1:28 Axel Lin
2012-03-02 5:14 ` Jin Park
2012-03-02 11:23 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-03-02 1:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Jin Park, Liam Girdwood, Mark Brown
The reason we add *pdev in struct aat2870_regulator is to use it
to get a pointer to struct aat2870_data.
Save a pointer to struct aat2870_data instead of pdev in struct
aat2870_regulator, this change makes the intention more clear.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/aat2870-regulator.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
index 685ad43..9ed5c5d 100644
--- a/drivers/regulator/aat2870-regulator.c
+++ b/drivers/regulator/aat2870-regulator.c
@@ -31,7 +31,7 @@
#include <linux/mfd/aat2870.h>
struct aat2870_regulator {
- struct platform_device *pdev;
+ struct aat2870_data *aat2870;
struct regulator_desc desc;
const int *voltages; /* uV */
@@ -60,7 +60,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
unsigned selector)
{
struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
- struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
+ struct aat2870_data *aat2870 = ri->aat2870;
return aat2870->update(aat2870, ri->voltage_addr, ri->voltage_mask,
selector << ri->voltage_shift);
@@ -69,7 +69,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
{
struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
- struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
+ struct aat2870_data *aat2870 = ri->aat2870;
u8 val;
int ret;
@@ -83,7 +83,7 @@ static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
static int aat2870_ldo_enable(struct regulator_dev *rdev)
{
struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
- struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
+ struct aat2870_data *aat2870 = ri->aat2870;
return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask,
ri->enable_mask);
@@ -92,7 +92,7 @@ static int aat2870_ldo_enable(struct regulator_dev *rdev)
static int aat2870_ldo_disable(struct regulator_dev *rdev)
{
struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
- struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
+ struct aat2870_data *aat2870 = ri->aat2870;
return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask, 0);
}
@@ -100,7 +100,7 @@ static int aat2870_ldo_disable(struct regulator_dev *rdev)
static int aat2870_ldo_is_enabled(struct regulator_dev *rdev)
{
struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
- struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
+ struct aat2870_data *aat2870 = ri->aat2870;
u8 val;
int ret;
@@ -185,7 +185,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "Invalid device ID, %d\n", pdev->id);
return -EINVAL;
}
- ri->pdev = pdev;
+ ri->aat2870 = dev_get_drvdata(pdev->dev.parent);
rdev = regulator_register(&ri->desc, &pdev->dev,
pdev->dev.platform_data, ri, NULL);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator
2012-03-02 1:28 [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator Axel Lin
@ 2012-03-02 5:14 ` Jin Park
2012-03-02 11:23 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Jin Park @ 2012-03-02 5:14 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown
Acked-by: Jin Park <jinyoungp@nvidia.com>
On 2012-03-02 오전 10:28, Axel Lin wrote:
> The reason we add *pdev in struct aat2870_regulator is to use it
> to get a pointer to struct aat2870_data.
> Save a pointer to struct aat2870_data instead of pdev in struct
> aat2870_regulator, this change makes the intention more clear.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/regulator/aat2870-regulator.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index 685ad43..9ed5c5d 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -31,7 +31,7 @@
> #include<linux/mfd/aat2870.h>
>
> struct aat2870_regulator {
> - struct platform_device *pdev;
> + struct aat2870_data *aat2870;
> struct regulator_desc desc;
>
> const int *voltages; /* uV */
> @@ -60,7 +60,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> unsigned selector)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->voltage_addr, ri->voltage_mask,
> selector<< ri->voltage_shift);
> @@ -69,7 +69,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -83,7 +83,7 @@ static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> static int aat2870_ldo_enable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask,
> ri->enable_mask);
> @@ -92,7 +92,7 @@ static int aat2870_ldo_enable(struct regulator_dev *rdev)
> static int aat2870_ldo_disable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask, 0);
> }
> @@ -100,7 +100,7 @@ static int aat2870_ldo_disable(struct regulator_dev *rdev)
> static int aat2870_ldo_is_enabled(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -185,7 +185,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "Invalid device ID, %d\n", pdev->id);
> return -EINVAL;
> }
> - ri->pdev = pdev;
> + ri->aat2870 = dev_get_drvdata(pdev->dev.parent);
>
> rdev = regulator_register(&ri->desc,&pdev->dev,
> pdev->dev.platform_data, ri, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator
2012-03-02 1:28 [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator Axel Lin
2012-03-02 5:14 ` Jin Park
@ 2012-03-02 11:23 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-03-02 11:23 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Jin Park, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Fri, Mar 02, 2012 at 09:28:44AM +0800, Axel Lin wrote:
> The reason we add *pdev in struct aat2870_regulator is to use it
> to get a pointer to struct aat2870_data.
> Save a pointer to struct aat2870_data instead of pdev in struct
> aat2870_regulator, this change makes the intention more clear.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-02 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 1:28 [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator Axel Lin
2012-03-02 5:14 ` Jin Park
2012-03-02 11:23 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).