From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756213Ab2CBMxX (ORCPT ); Fri, 2 Mar 2012 07:53:23 -0500 Received: from acsinet15.oracle.com ([141.146.126.227]:29671 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753Ab2CBMxW (ORCPT ); Fri, 2 Mar 2012 07:53:22 -0500 Date: Fri, 2 Mar 2012 15:55:02 +0300 From: Dan Carpenter To: Neil Horman Cc: Joerg Roedel , Stanislaw Gruszka , Paul Gortmaker , Alan Stern , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] dma-debug: debugfs_create_bool() takes a u32 pointer Message-ID: <20120302125502.GW1003@mwanda> References: <20120302065832.GE24508@elgon.mountain> <20120302112203.GA14827@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c7rykKtsZvepKFKR" Content-Disposition: inline In-Reply-To: <20120302112203.GA14827@hmsreliant.think-freely.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4F50C2AD.0056,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --c7rykKtsZvepKFKR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 02, 2012 at 06:22:03AM -0500, Neil Horman wrote: > This certainly works, but a quick search of call sites shows this isn't the only > place someone passes a bool to debugfs_create_bool. I think the better solution > would be to change debugfs_create_bool and its corresponding read/write methods > to actually work with a bool type, and then clean all the call sites to pass in > a bool properly, instead of a u32. There is only one other call site which gets this wrong, and I sent a fix for that today as well. But yes, you're probably right that would be cleaner. regards, dan carpenter --c7rykKtsZvepKFKR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPUMMmAAoJEOnZkXI/YHqRpDMP/36dETq3d6BwrI4I9RE3fStJ 7mqSDha/OAyR2KQ9Com1wAMtHIhkbpp2NSxr5ighxV4Iv2inSj1v2cJM0xatssvl OseuhWWFxB/KMcBbixznBbcjT6sT5F6UCzG+es7VHgHsmYY+qyQfM6slbLKnBofK g477Ta8Aj7qNvHt+m7RG6Xg1cAUR6GKMBsp+z1xD7zWLPaI/2a4jsHBxA3QwOwzD gE1PVTypNNkVlFokFk2XSOQKUKEIjnA7+p4yEe9ri4cs4mZwvIcioNqIUI5Ch8j2 dTMcGNtjt3KyGVAXGDANZTT2XfDmbEgjZ0yz3yH2x4I5FW01MbgO34O6lTgi2FbJ 1NyBXfKUYuE7kcn3bRrBJfCUKQKFTrctn333Hp/XEq1AZQXMFDtrqE2pHrdpUj0n cKpSZhDLL08TjAkI1Xh8rdN6IwQ/AF4azAqOSqszEG0sHAm62lGe84vRrKEeNGoU M4/iLOkkzkmJ0q/WVpj27d/3ZdPNF1f/NVAKjdqOPY1CBlaoGiFNHElxN+cpfJPs eWQMTIJsoQMTNSnPs837krMW+j71aUprrjB3AIhdKkKNC5bQ6QAR2VjVgdQYSfyK d4YNcD2J8Ycm86uCx7WaD5nZVuLegXU5eBSEbDAC8M/bE4mxh4m7EE4vynzqWsP5 2ogX+tTT8ZAe5n3Zye+s =hmC7 -----END PGP SIGNATURE----- --c7rykKtsZvepKFKR--