From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, ravitillo@lbl.gov, khandual@linux.vnet.ibm.com,
asharma@fb.com, robert.richter@amd.com, ming.m.lin@intel.com,
vweaver1@eecs.utk.edu, andi@firstfloor.org
Subject: Re: [PATCH] perf report: auto-detect branch stack sampling mode
Date: Fri, 2 Mar 2012 16:08:22 -0300 [thread overview]
Message-ID: <20120302190822.GA12431@infradead.org> (raw)
In-Reply-To: <CABPqkBTBkrA5qdeyhznr48Pqa9L-EX-LABypX55f_GoMRk-hDg@mail.gmail.com>
Em Fri, Mar 02, 2012 at 06:47:38PM +0100, Stephane Eranian escreveu:
> Arnaldo,
>
> What do you think about this patch?
I'm processing perf/core patches today, will get to this one and merge
or let you know objections,
- Arnaldo
>
> On Fri, Feb 24, 2012 at 4:51 PM, Stephane Eranian <eranian@google.com> wrote:
> > On Fri, Feb 24, 2012 at 4:49 PM, David Ahern <dsahern@gmail.com> wrote:
> >> On 2/24/12 8:40 AM, Stephane Eranian wrote:
> >>>
> >>> No, I don't. Read the code carefully. The for loop sets all known feature
> >>> bits.
> >>> Then, the ones not necessary or unused are turned off individually.
> >>
> >>
> >> Ok, I see now. The __set_feat loop is earlier in builtin-record.c, not the
> >> util code.
> >>
> > Yeah. Arnaldo simplified the original code in builtin-record.c to have the loop
> > instead of individual set_feat().
> >
> >> David
next prev parent reply other threads:[~2012-03-02 19:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 9:40 [PATCH] perf report: auto-detect branch stack sampling mode Stephane Eranian
2012-02-24 15:24 ` David Ahern
2012-02-24 15:28 ` Stephane Eranian
2012-02-24 15:31 ` David Ahern
2012-02-24 15:40 ` Stephane Eranian
2012-02-24 15:49 ` David Ahern
2012-02-24 15:51 ` Stephane Eranian
2012-03-02 17:47 ` Stephane Eranian
2012-03-02 19:08 ` Arnaldo Carvalho de Melo [this message]
2012-03-03 19:43 ` Arnaldo Carvalho de Melo
2012-03-05 10:49 ` Ingo Molnar
2012-03-05 11:11 ` Peter Zijlstra
2012-03-05 15:47 ` Ingo Molnar
2012-03-05 15:50 ` Ingo Molnar
2012-03-05 15:56 ` Ingo Molnar
2012-03-05 16:30 ` Peter Zijlstra
2012-03-05 16:32 ` Stephane Eranian
2012-03-05 17:20 ` Ingo Molnar
2012-03-05 20:35 ` Arnaldo Carvalho de Melo
2012-03-05 21:43 ` Arun Sharma
2012-03-05 22:26 ` Arnaldo Carvalho de Melo
2012-03-05 23:35 ` Arun Sharma
2012-03-06 3:06 ` Arnaldo Carvalho de Melo
2012-03-06 6:27 ` Ingo Molnar
2012-03-06 6:25 ` Ingo Molnar
2012-03-07 1:57 ` [RFC] perf report: Implement symbol filtering on TUI Namhyung Kim
2012-03-07 6:07 ` Ingo Molnar
2012-03-07 8:04 ` Namhyung Kim
2012-03-08 10:44 ` Ingo Molnar
2012-03-09 1:53 ` Namhyung Kim
2012-03-09 7:36 ` Ingo Molnar
2012-03-09 8:03 ` Namhyung Kim
2012-03-14 23:11 ` Arun Sharma
2012-03-15 0:44 ` Namhyung Kim
2012-03-15 21:46 ` Arun Sharma
2012-03-05 15:52 ` [PATCH] perf report: auto-detect branch stack sampling mode Stephane Eranian
2012-03-07 12:49 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302190822.GA12431@infradead.org \
--to=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=ravitillo@lbl.gov \
--cc=robert.richter@amd.com \
--cc=vweaver1@eecs.utk.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).