From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006Ab2CCSGW (ORCPT ); Sat, 3 Mar 2012 13:06:22 -0500 Received: from imr4.ericy.com ([198.24.6.9]:40436 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434Ab2CCSGU (ORCPT ); Sat, 3 Mar 2012 13:06:20 -0500 Date: Sat, 3 Mar 2012 10:04:02 -0800 From: Guenter Roeck To: Mark Brown CC: Amit Daniel Kachhap , "linux-samsung-soc@vger.kernel.org" , "linaro-dev@lists.linaro.org" , "patches@linaro.org" , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-acpi@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" Subject: Re: [lm-sensors] [linux-pm] [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory Message-ID: <20120303180402.GA30062@ericsson.com> References: <1330772767-16120-1-git-send-email-amit.kachhap@linaro.org> <1330772767-16120-3-git-send-email-amit.kachhap@linaro.org> <20120303164410.GB1495@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120303164410.GB1495@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 03, 2012 at 11:44:10AM -0500, Mark Brown wrote: > On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote: > > This movement is needed because the hwmon entries and corresponding > > sysfs interface is a duplicate of utilities already provided by > > driver/thermal/thermal_sys.c. The goal is to place it in mfd folder > > and add necessary calls to get the temperature information. > > > --- a/Documentation/hwmon/exynos4_tmu > > +++ /dev/null > > Moving this seems to be a failure, the device is exposing a hwmon > interface even if you've moved the code to mfd (though it doesn't > actually look like a multi-function device at all as far as I can see - > usually a MFD would have a bunch of unrelated functionality while this > has one function used by two subsystems). > > If anything it looks like the ADC driver ought to be moved into IIO with > either generic or Exynos specific function drivers layered on top of it > in hwmon and thermal making use of the values that are read. > I would agree. Or maybe move it all to thermal, since thermal devices register the hwmon subsystem. Guenter