From: "Ted Ts'o" <tytso@mit.edu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "John G. Heim" <jheim@math.wisc.edu>, linux-kernel@vger.kernel.org
Subject: Re: speakup bug
Date: Sat, 3 Mar 2012 17:01:11 -0500 [thread overview]
Message-ID: <20120303220111.GB6117@thunk.org> (raw)
In-Reply-To: <20120303173916.7eca9391@pyramind.ukuu.org.uk>
On Sat, Mar 03, 2012 at 05:39:16PM +0000, Alan Cox wrote:
> On Sat, 3 Mar 2012 11:18:12 -0600
> "John G. Heim" <jheim@math.wisc.edu> wrote:
>
> > I need help fixing a bug in the driver for serial hardware speech synths in
> > the speakup screen reader. According to the comments in the code, it is in a
> > part of the code that is trying to "steal" the serial port.
>
> Yes - and the code is broken. To start with it's assumig a legacy PC
> serial port at 0x3F8 and that it can beat the serial layer to it.
Worse yet, it busy waits when sending characters to the UART. Ugh...
> The proper fix is to make the drivers work via the serial layer properly.
> The speakup people have been told this repeatedly for years and years
> which is why their drivers work on less and less systems and won't run
> with things PCI or USB serial ports, and why they are forever buried in
> staging.
The driver desperately needs to be rewritten to attach to the serial
layer via a tty line discpline. That way it will work on other types
of serial ports (i.e., PCI bus attached and USB devices).
- Ted
next prev parent reply other threads:[~2012-03-03 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 17:18 speakup bug John G. Heim
2012-03-03 17:39 ` Alan Cox
2012-03-03 22:01 ` Ted Ts'o [this message]
2012-03-04 0:01 ` John G. Heim
2012-03-04 0:18 ` Samuel Thibault
2012-03-04 0:21 ` Samuel Thibault
2012-03-04 0:41 ` Ted Ts'o
2012-03-04 0:43 ` Samuel Thibault
2012-03-04 0:44 ` Samuel Thibault
2012-03-04 1:41 ` Ted Ts'o
2012-03-04 0:26 ` Ted Ts'o
2012-03-04 2:03 ` John G. Heim
2012-03-04 21:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120303220111.GB6117@thunk.org \
--to=tytso@mit.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jheim@math.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox