From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Eric Wollesen <ericw@xmtp.net>,
Doug Thompson <dougthompson@xmission.com>,
list-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] edac i5000, i5400: fix pointer math in i5000_get_mc_regs()
Date: Mon, 5 Mar 2012 12:52:44 +0300 [thread overview]
Message-ID: <20120305095244.GG1003@mwanda> (raw)
In-Reply-To: <4F548B43.6010802@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On Mon, Mar 05, 2012 at 10:45:39AM +0100, walter harms wrote:
>
>
> Am 05.03.2012 10:01, schrieb Dan Carpenter:
> > "pvt->ambase" is a u64 datatype. The intent here is to fill the first
> > half in the first call to pci_read_config_dword() and the other half in
> > the second. Unfortunately the pointer math is wrong so we set the wrong
> > data.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: Redid it as with a union as Walter Harms suggested.
> > Fixed the same bug in i5400_edac.c as well.
> >
> > I don't have this hardware, so please review carefully.
> >
> > diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c
> > index 74d6ec34..083e80a 100644
> > --- a/drivers/edac/i5400_edac.c
> > +++ b/drivers/edac/i5400_edac.c
> > @@ -343,7 +343,13 @@ struct i5400_pvt {
> > struct pci_dev *branch_1; /* 22.0 */
> >
> > u16 tolm; /* top of low memory */
> > - u64 ambase; /* AMB BAR */
> > + union {
> > + u64 ambase; /* AMB BAR */
> > + struct {
> > + u32 ambase_bottom;
> > + u32 ambase_top;
> > + } u;
> > + };
> >
>
> would this work with alignment=8 ?
Are you asking or telling?
I guess I'll add a __packed and resend in case it's an issue.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-05 9:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 6:54 [patch] edac i5000: fix pointer math in i5000_get_mc_regs() Dan Carpenter
2012-03-02 9:00 ` walter harms
2012-03-02 19:09 ` Dan Carpenter
2012-03-02 19:20 ` walter harms
2012-03-05 9:01 ` [patch v2] edac i5000, i5400: " Dan Carpenter
2012-03-05 9:45 ` walter harms
2012-03-05 9:52 ` Dan Carpenter [this message]
2012-03-05 10:07 ` walter harms
2012-03-06 6:38 ` [patch v3] " Dan Carpenter
2012-03-06 8:50 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305095244.GG1003@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dougthompson@xmission.com \
--cc=ericw@xmtp.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list-edac@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).