From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756642Ab2CEJug (ORCPT ); Mon, 5 Mar 2012 04:50:36 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:36233 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756598Ab2CEJue (ORCPT ); Mon, 5 Mar 2012 04:50:34 -0500 Date: Mon, 5 Mar 2012 12:52:44 +0300 From: Dan Carpenter To: walter harms Cc: Eric Wollesen , Doug Thompson , list-edac@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch v2] edac i5000, i5400: fix pointer math in i5000_get_mc_regs() Message-ID: <20120305095244.GG1003@mwanda> References: <20120302065441.GB24508@elgon.mountain> <4F508C16.30900@bfs.de> <20120305090109.GM22598@mwanda> <4F548B43.6010802@bfs.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mXWEJCq0x1D2MX0F" Content-Disposition: inline In-Reply-To: <4F548B43.6010802@bfs.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090206.4F548C67.007E,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mXWEJCq0x1D2MX0F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 05, 2012 at 10:45:39AM +0100, walter harms wrote: >=20 >=20 > Am 05.03.2012 10:01, schrieb Dan Carpenter: > > "pvt->ambase" is a u64 datatype. The intent here is to fill the first > > half in the first call to pci_read_config_dword() and the other half in > > the second. Unfortunately the pointer math is wrong so we set the wrong > > data. > >=20 > > Signed-off-by: Dan Carpenter > > --- > > v2: Redid it as with a union as Walter Harms suggested. > > Fixed the same bug in i5400_edac.c as well. > >=20 > > I don't have this hardware, so please review carefully. > >=20 > > diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c > > index 74d6ec34..083e80a 100644 > > --- a/drivers/edac/i5400_edac.c > > +++ b/drivers/edac/i5400_edac.c > > @@ -343,7 +343,13 @@ struct i5400_pvt { > > struct pci_dev *branch_1; /* 22.0 */ > > =20 > > u16 tolm; /* top of low memory */ > > - u64 ambase; /* AMB BAR */ > > + union { > > + u64 ambase; /* AMB BAR */ > > + struct { > > + u32 ambase_bottom; > > + u32 ambase_top; > > + } u; > > + }; > > =20 >=20 > would this work with alignment=3D8 ? Are you asking or telling? I guess I'll add a __packed and resend in case it's an issue. regards, dan carpenter --mXWEJCq0x1D2MX0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPVIzrAAoJEOnZkXI/YHqRarwQAIRwMzHZ1YOgQUGUhRqktgJT hXeyL3lDCSioYJIfJf3YSO98th7KfXxPuZBKPRbROgP5I2KbrJjKM+4JkI8kfMaT XsRYDzVDh+icx7IkNub6mFBvUAo4yy2BwgNROQn2jzJ2bMhdXqO0XGBpePmlGf89 gtaGowAGYRyDrZJcsbNCi9vsi8awHB/adrEgsy50xPjXWhTYk3Lyg3bG7lRdRUux LKMDeQKiaQXhhRD42raFDaPRrF/Lb5/Ktbo51vP2ZnwxLsaKYcoFO0Apbk8VIMT6 66YxzW8xBXxEK7KuLSW6d5NzpepogvBwreUpTOBAU8boFv9o6fJb7MWFa37JvlyE DPAS3OhZmnKLxopqj8hnZtwE5vFc0pcsfjqAyziYvd5cBRQw1jhftE4J+623FtsN mGxxtlXH1pAJwAG5tUaVjl8AszIEQYOhpw7KOcXEBgeGMauyoe+cwyGIZJcOscrP bx+8RDCJA9MOcGMFJFVcsFi1qcQJcsmUQ8mZ2q8WGk04mmzkm12XKQQEwrPu49ck t6Sh/Oh/URdKRxtxkpaRrXPitMwnTdecI0Xw3JE/MQy9SDD+Aygf0h6dMnZsRjd3 wBPVJhCVgLyQGcwxnAPhcRvFtwGd0ICVf0F8Xou84rhBEs7dlgw3IrN9O4SzVP1n X4XGLGSbIq1JcNaDWnPw =1Odh -----END PGP SIGNATURE----- --mXWEJCq0x1D2MX0F--