public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Matt Helsley <matthltc@us.ibm.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Kees Cook <keescook@chromium.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Pavel Emelyanov <xemul@parallels.com>, Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] turn mm->exe_file into mm->exe_path
Date: Mon, 5 Mar 2012 16:28:26 +0100	[thread overview]
Message-ID: <20120305152826.GA12419@redhat.com> (raw)

I think the patch is simple and self-explanatory, it simply
does s/mm->exe_file/mm->exe_path/.

Why do we need mm->exe_file? IIUC, there are 2 reasons:

	1. we do not want O(n) proc/pid/exe looking for the 1st
	   VM_EXECUTABLE vma.

	2. we do not want to rely on vma->vm_file->f_path,
	   bprm->file->f_op->mmap can change ->vm_file.

Unless there was another subtle reason, "struct path *exe_path"
can equally work but it looks more clear.



And can't we also remove added_exe_file_vma/removed_exe_file_vma?
Why do we need mm->num_exe_file_vmas? Afaics it is only needed to
"free" mm->exe_file if the application unmaps all these vmas. Say,
to allow to unmount fs.

Can't we simply add PR_CLEAR_MM_EXE_PATH instead? Of course it is
not enough if ->vm_file still has a reference. But c/r people want
PR_SET_MM_EXE_FILE anyway, see http://marc.info/?t=133052865500016
So perhaps we can add PR_SET_MM_EXE_PATH which accepts NULL as well
and kill this counter?

Oleg.


             reply	other threads:[~2012-03-05 15:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 15:28 Oleg Nesterov [this message]
2012-03-05 15:28 ` [PATCH 1/1] turn mm->exe_file into mm->exe_path Oleg Nesterov
2012-03-05 17:05 ` [PATCH 0/1] " Cyrill Gorcunov
2012-03-05 17:33   ` Oleg Nesterov
2012-03-05 18:25     ` Cyrill Gorcunov
2012-03-05 21:14 ` Matt Helsley
2012-03-06 16:28   ` Oleg Nesterov
2012-03-06 16:41     ` Cyrill Gorcunov
2012-03-06 18:16     ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120305152826.GA12419@redhat.com \
    --to=oleg@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@openvz.org \
    --cc=keescook@chromium.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    --cc=tj@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox