From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757901Ab2CEXex (ORCPT ); Mon, 5 Mar 2012 18:34:53 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:39038 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757245Ab2CEXev (ORCPT ); Mon, 5 Mar 2012 18:34:51 -0500 Date: Mon, 5 Mar 2012 17:34:45 -0600 From: Seth Forshee To: Randy Dunlap Cc: Matthew Garrett , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, Len Brown , Azael Avalos , Thomas Renninger , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] toshiba_acpi: Expanded hotkey support Message-ID: <20120305233445.GD16312@ubuntu-macmini> Mail-Followup-To: Randy Dunlap , Matthew Garrett , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, Len Brown , Azael Avalos , Thomas Renninger , linux-kernel@vger.kernel.org References: <1326915852-19896-1-git-send-email-seth.forshee@canonical.com> <20120206150658.GE6414@ubuntu-macmini> <20120206151548.GA30255@srcf.ucam.org> <20120305220407.GA16312@ubuntu-macmini> <4F5545BB.5010608@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F5545BB.5010608@xenotime.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 05, 2012 at 03:01:15PM -0800, Randy Dunlap wrote: > On 03/05/2012 02:04 PM, Seth Forshee wrote: > > > On Mon, Feb 06, 2012 at 03:15:48PM +0000, Matthew Garrett wrote: > >> On Mon, Feb 06, 2012 at 09:06:58AM -0600, Seth Forshee wrote: > >> > >>> Matthew: Just wondering if there are more issues that need to be > >>> addressed with this round of patches, or if they're looking okay at this > >>> point. > >> > >> I'm fine with them at this point, just waiting on Len to give feedback > >> on the ACPI patch. > > > > Well, I've been trying to get some comment on the ACPI patch, to no > > avail. Unless there's some other option, I guess I'll just resend the > > patches using an alternative method for getting the EC handle. > > > I did test this patch series on 3.3-rc5 to see if it would > help with the touchpad on/off key on my Toshiba Portege. > > The patch series didn't have any ill effects, nor did it help > with the touchpad on/off key. :( Is it only that hotkey that doesn't work, or do the others fail to work as well? If it's only that key that doesn't work, I'd suggest using input-events to determine exactly which device the other hotkey events are coming from (it might be more than one) and to verify there really isn't any event coming out for that key. If there's no event at all for the key, check dmesg and see if any messages are printed there when you press the touchpad key. Seth