public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tglx@linutronix.de, hpa@zytor.com, alex.shi@intel.com,
	cl@gentwo.org, sfr@canb.auug.org.au, tj@kernel.org,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch 5/8] x86: use this_cpu_xxx to replace percpu_xxx funcs
Date: Tue, 6 Mar 2012 08:57:40 +0100	[thread overview]
Message-ID: <20120306075740.GF23669@elte.hu> (raw)
In-Reply-To: <20120305235532.28f407bf.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 6 Mar 2012 08:46:01 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> 
> > Will percpu_write() be removed altogether? If so then the 
> > changelog should say *that*, and explain that on x86 this is a 
> > simple renaming of the API, not a long explanation about 
> > scenarios that don't actually matter.
> > 
> > If percpu_write() is not being removed then I don't see how this 
> > patch is an improvement: it's supposed to result in the same 
> > instructions being emitted, and __this_cpu_write() et al are 
> > distinctly longer to write ...
> > 
> > So what's the plan here?
> 
> All percpu_xxx() functions get removed.

Fair enough - then please see my namespace comments for the 
other patch, before we start spreading these APIs to hundreds of 
places ...

Also, IMHO the lack of debugging API is troubling as well. 
Thomas found a couple of really, really hairy this_cpu related 
bugs.

Thanks,

	Ingo

  reply	other threads:[~2012-03-06  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120305230515.A9238A02AE@akpm.mtv.corp.google.com>
2012-03-06  7:46 ` [patch 5/8] x86: use this_cpu_xxx to replace percpu_xxx funcs Ingo Molnar
2012-03-06  7:55   ` Andrew Morton
2012-03-06  7:57     ` Ingo Molnar [this message]
2012-03-06 16:33       ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120306075740.GF23669@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=cl@gentwo.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox