[PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

Greg's e-mail address was old. So, I resend it.

Though I've tested this patch,
http://marc.info/?l=linux-usb&m=132825305710285&w=2,
I've received the following reports.
http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

So, I added header file for these symbols.
Using this patch, this compile error must be disappeared.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/usb/gadget/pch_udc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index 350dbcd..6530706 100644
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -16,6 +16,7 @@
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
 #include <linux/gpio.h>
+#include <linux/irq.h>
 
 /* GPIO port for VBUS detecting */
 static int vbus_gpio_port = -1;		/* GPIO port number (-1:Not used) */
-- 
1.7.7.6

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

Hi

Add information.

My develop environment is on x86.

According to following report,
  http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
  http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

This occurred on sparc64.

I suspect this issue ins GPIO implementation for sparc64.
Does sparc64 support GPIO interrupt ?
(Even x86, before 2.6.39, GPIO interrupt is not implemented !)

Additionally, this driver is for companion chip of Intel Atom E6xx series.
So, this driver is never used for except x86, e.g. sparc.

thanks
-- 
ROHM Co., Ltd.
tomoya

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Greg Kroah-Hartman]

On Tue, Mar 06, 2012 at 03:39:37PM +0900, Tomoya MORINAGA wrote:
> Hi
> 
> Add information.
> 
> My develop environment is on x86.
> 
> According to following report,
>   http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
>   http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
> 
> This occurred on sparc64.
> 
> I suspect this issue ins GPIO implementation for sparc64.
> Does sparc64 support GPIO interrupt ?
> (Even x86, before 2.6.39, GPIO interrupt is not implemented !)
> 
> Additionally, this driver is for companion chip of Intel Atom E6xx series.
> So, this driver is never used for except x86, e.g. sparc.

Then the Kconfig file should probably only enable it on x86 to prevent
these kinds of things :)

thanks,

greg k-h

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

On Tue, Mar 6, 2012 at 11:58 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>> Additionally, this driver is for companion chip of Intel Atom E6xx series.
>> So, this driver is never used for except x86, e.g. sparc.
>
> Then the Kconfig file should probably only enable it on x86 to prevent
> these kinds of things :)

Yes, you are right.
I should have added "x86" to Kconfig.

thanks,
-- 
ROHM Co., Ltd.
tomoya