From: Wolfram Sang <w.sang@pengutronix.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
khali@linux-fr.org, ben-linux@fluff.org,
grant.likely@secretlab.ca, linus.walleij@linaro.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
Date: Wed, 7 Mar 2012 18:39:22 +0100 [thread overview]
Message-ID: <20120307173922.GB1130@pengutronix.de> (raw)
In-Reply-To: <20120307173157.GT3107@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Wed, Mar 07, 2012 at 05:31:57PM +0000, Mark Brown wrote:
> On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote:
> > The gpio core driver (gpio library) supports the open
> > drain pin handling. Therefore, it is not require it
> > to handle in the i2c-gpio driver, just require
> > to pass the OPEN_DRAIN type flag when requesting the gpio.
>
> Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Typo ;)
>
> but note that this is a new gpiolib feature in -next and will need to
> either be applied via Grant's tree or wait until after the merge window.
I'll pick it for v3.5 later. Thanks for the review!
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-03-07 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 13:38 [PATCH V1] i2c: gpio: Use open drain support from gpio driver Laxman Dewangan
2012-03-07 17:31 ` Mark Brown
2012-03-07 17:39 ` Wolfram Sang [this message]
2012-03-07 17:44 ` Mark Brown
2012-03-07 18:08 ` Laxman Dewangan
2012-03-07 19:17 ` Mark Brown
2012-03-08 6:24 ` Linus Walleij
2012-03-08 7:41 ` Wolfram Sang
2012-03-08 8:59 ` Linus Walleij
2012-03-08 11:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307173922.GB1130@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox