From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
adobriyan@gmail.com, ebiederm@xmission.com,
keescook@chromium.org, kosaki.motohiro@jp.fujitsu.com,
matthltc@us.ibm.com, tj@kernel.org, xemul@parallels.com
Subject: Re: + mm-exec-rename-mm-exe_file-to-mm-exe_path.patch added to -mm tree
Date: Thu, 8 Mar 2012 00:37:52 +0400 [thread overview]
Message-ID: <20120307203752.GB6191@moon> (raw)
In-Reply-To: <20120307195104.GA5071@redhat.com>
On Wed, Mar 07, 2012 at 08:51:04PM +0100, Oleg Nesterov wrote:
...
>
> > OOPs. Sorry for false alarm, Oleg!
>
> No, thanks for the report and analysis.
>
> Indeed, the patch is deadly wrong. Somehow I missed that ->f_path
> is not the pointer! So set_mm_exe_path(&bprm->file->f_path) is
> is obvioulsy wrong. I didn't bother to think about "&" think call
> needs.
>
OK. So it is not a false alarm as I thought after
trying to write a call trace, good to know ;)
Anyway, this problem is hard to repeat and I have
no idea how I managed to hit it in first place.
It was indeed "easily" until I rebooted the test
machine.
Cyrill
prev parent reply other threads:[~2012-03-07 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120306231325.D4B26A0395@akpm.mtv.corp.google.com>
[not found] ` <20120307162630.GG20558@moon>
2012-03-07 17:41 ` + mm-exec-rename-mm-exe_file-to-mm-exe_path.patch added to -mm tree Oleg Nesterov
2012-03-07 19:34 ` Cyrill Gorcunov
2012-03-07 19:51 ` Oleg Nesterov
2012-03-07 20:37 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307203752.GB6191@moon \
--to=gorcunov@openvz.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox