Re: [PATCH 01/13] android: lowmemorykiller: Fix warning on 64bit

John Stultz
2012-03-07T22:25:01Z

On Wed, 2012-03-07 at 14:04 -0800, Greg KH wrote:
> On Wed, Mar 07, 2012 at 01:58:11PM -0800, John Stultz wrote:
> > Fixes the following warning on 64bit:
> > drivers/staging/android/lowmemorykiller.c: In function ‘__check_minfree’:
> > drivers/staging/android/lowmemorykiller.c:215: warning: return from incompatible pointer type
> >
> > CC: Greg KH <gregkh@linuxfoundation.org>
> > CC: Android Kernel Team <kernel-team@android.com>
> > Signed-off-by: John Stultz <john.stultz@linaro.org>
> > ---
> > drivers/staging/android/lowmemorykiller.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> > index 052b43e..15a59c1 100644
> > --- a/drivers/staging/android/lowmemorykiller.c
> > +++ b/drivers/staging/android/lowmemorykiller.c
> > @@ -212,7 +212,7 @@ static void __exit lowmem_exit(void)
> > module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> > module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size,
> > S_IRUGO | S_IWUSR);
> > -module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> > +module_param_array_named(minfree, lowmem_minfree, ulong, &lowmem_minfree_size,
> > S_IRUGO | S_IWUSR);
>
> No, the correct fix for this is to make lowmem_minfree an int, not
> size_t, right? I made that fix an hour ago in my tree.

Looks ok to me. I'll go ahead and drop this then.

thanks
-john