From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Seebach <peter.seebach@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>, Anton Blanchard <anton@samba.org>,
paulus@samba.org, peterz@infradead.org, dsahern@gmail.com,
fweisbec@gmail.com, yanmin_zhang@linux.intel.com,
emunson@mgebm.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Incorrect use of snprintf results in SEGV
Date: Wed, 7 Mar 2012 21:58:27 -0300 [thread overview]
Message-ID: <20120308005827.GE18932@infradead.org> (raw)
In-Reply-To: <20120307151951.7e84adb6@wrlaptop>
Em Wed, Mar 07, 2012 at 03:19:51PM -0600, Peter Seebach escreveu:
> On Wed, 7 Mar 2012 21:37:25 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > We *DONT* want to make APIs more fragile just to accomodate a
> > rare, esoteric usecase!
>
> I would view snprintf as an API which already exists. If it's the
> wrong API, by all means, write a different one -- but I would suggest
> not using the same name for it. If a function is going to be called
> snprintf, IMO it should have the semantics of snprintf. If those are
> the wrong semantics (and they may well be), then I would say use a
> function which has the right semantics, and isn't named snprintf.
Right, its more a case of: Don't assume people do things you think are
reasonable, read carefully and follow the instructions.
At least it is not as long as other EULAs, it is much, much shorter,
but managed to be just as non intuitive.
- Arnaldo
next prev parent reply other threads:[~2012-03-08 0:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 0:42 [PATCH] perf: Incorrect use of snprintf results in SEGV Anton Blanchard
2012-03-07 0:49 ` Peter Seebach
2012-03-07 1:09 ` Arnaldo Carvalho de Melo
2012-03-07 1:29 ` Peter Seebach
2012-03-07 18:44 ` Nick Bowler
2012-03-07 20:24 ` Peter Seebach
2012-03-07 20:37 ` Ingo Molnar
2012-03-07 20:59 ` Peter Zijlstra
2012-03-07 21:28 ` Peter Seebach
2012-03-08 7:34 ` Ingo Molnar
2012-03-08 8:51 ` Peter Seebach
2012-03-07 21:19 ` Peter Seebach
2012-03-08 0:58 ` Arnaldo Carvalho de Melo [this message]
2012-03-08 7:48 ` Ingo Molnar
2012-03-08 7:52 ` Ingo Molnar
2012-03-09 19:00 ` Peter Seebach
2012-03-14 19:59 ` [tip:perf/urgent] perf tools: " tip-bot for Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308005827.GE18932@infradead.org \
--to=acme@redhat.com \
--cc=anton@samba.org \
--cc=dsahern@gmail.com \
--cc=emunson@mgebm.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peter.seebach@windriver.com \
--cc=peterz@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox